[ty] Use invalid-assignment error code for invalid assignments to ClassVars by AlexWaygood · Pull Request #20156 · astral-sh/ruff (original) (raw)

added the ty

Multi-file analysis & type inference

label

Aug 29, 2025

AlexWaygood added a commit that referenced this pull request

Aug 29, 2025

…nts to ClassVars" (#20158)

Reverts #20156. As @sharkdp noted in his post-merge review, there were several issues with that PR that I didn't spot before merging — but I'm out for four days now, and would rather not leave things in an inconsistent state for that long. I'll revisit this on Wednesday.

dcreager added a commit that referenced this pull request

Sep 2, 2025

• main: (28 commits) [ty] __class_getitem__ is a classmethod (#20192) [ty] Support __init_subclass__ (#20190) Update dependency ruff to v0.12.11 (#20184) Update rui314/setup-mold digest to 725a879 (#20181) Update CodSpeedHQ/action action to v3.8.1 (#20183) Update cargo-bins/cargo-binstall action to v1.15.3 (#20182) Update Rust crate camino to v1.1.12 (#20185) Update Rust crate clap to v4.5.46 (#20186) Update Rust crate mimalloc to v0.1.48 (#20187) [ty] Sync vendored typeshed stubs (#20188) [ty] improve cycle-detection coverage for apply_type_mapping (#20159) [ty] don't assume that deferred type inference means deferred name resolution (#20160) Less confidently mark f-strings as empty when inferring truthiness (#20152) [ty] skip a slow seed in fuzzer (#20161) Revert "[ty] Use invalid-assignment error code for invalid assignments to ClassVars" (#20158) [ty] add six ecosystem projects to good.txt (#20157) [ty] Use invalid-assignment error code for invalid assignments to ClassVars (#20156) [ty] minor TypedDict fixes (#20146) [ty] ensure union normalization really normalizes (#20147) [ty] typecheck dict methods for TypedDict (#19874) ...

second-ed pushed a commit to second-ed/ruff that referenced this pull request

Sep 9, 2025

…ClassVar`s (astral-sh#20156)

Summary

This error is about assigning to attributes rather than reading attributes, so I think invalid-assignment makes more sense than invalid-attribute-access

Test Plan

existing mdtests updated

second-ed pushed a commit to second-ed/ruff that referenced this pull request

Sep 9, 2025

…nts to ClassVars" (astral-sh#20158)

Reverts astral-sh#20156. As @sharkdp noted in his post-merge review, there were several issues with that PR that I didn't spot before merging — but I'm out for four days now, and would rather not leave things in an inconsistent state for that long. I'll revisit this on Wednesday.

KotlinIsland pushed a commit to KotlinIsland/basedpython that referenced this pull request

May 1, 2026

…nts to ClassVars" (#20158)

Reverts astral-sh/ruff#20156. As @sharkdp noted in his post-merge review, there were several issues with that PR that I didn't spot before merging — but I'm out for four days now, and would rather not leave things in an inconsistent state for that long. I'll revisit this on Wednesday.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})