Ignore deprecated rules unless selected by exact code by LoicRiegel · Pull Request #20167 · astral-sh/ruff (original) (raw)

added 2 commits

August 30, 2025 14:17

…in a minor version increase

ntBre added breaking

Breaking API change

cli

Related to the command-line interface

labels

Sep 3, 2025

ntBre changed the title~~Feat/ignore deprecated rules by unless selected by exact code~~ Ignore deprecated rules unless selected by exact code

Sep 8, 2025

ntBre changed the base branch from main to brent/0.13.0

September 8, 2025 15:59

ntBre mentioned this pull request

Sep 8, 2025

2 tasks

ntBre pushed a commit that referenced this pull request

Sep 8, 2025

Summary

Closes #18349

After this change:

All deprecated rules are deselected by default
They are only selected if the user specifically selects them by code, e.g. --select UP038
Thus, --select ALL --select UP --select UP0 won't select the deprecated rule UP038
Documented the change in version policy. From now on, deprecating a rule should increase the minor version

Test Plan

Integration tests in "integration_tests.rs"

Also tested with a temporary test package:

~> ../../ruff/target/debug/ruff.exe check --select UP038
warning: Rule `UP038` is deprecated and will be removed in a future release.
warning: Detected debug build without --no-cache.
UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
 --> main.py:2:11
  |
1 | def main():
2 |     print(isinstance(25, (str, int)))
  |           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
help: Convert to `X | Y`

Found 1 error.
No fixes available (1 hidden fix can be enabled with the `--unsafe-fixes` option).

~> ../../ruff/target/debug/ruff.exe check --select UP03
warning: Detected debug build without --no-cache.
All checks passed!

~> ../../ruff/target/debug/ruff.exe check --select UP0
warning: Detected debug build without --no-cache.
All checks passed!

~> ../../ruff/target/debug/ruff.exe check --select UP
warning: Detected debug build without --no-cache.
All checks passed!

~> ../../ruff/target/debug/ruff.exe check --select ALL
# warnings and errors, but because of other errors, UP038 was deselected

ntBre pushed a commit that referenced this pull request

Sep 10, 2025

Summary

Closes #18349

After this change:

All deprecated rules are deselected by default
They are only selected if the user specifically selects them by code, e.g. --select UP038
Thus, --select ALL --select UP --select UP0 won't select the deprecated rule UP038
Documented the change in version policy. From now on, deprecating a rule should increase the minor version

Test Plan

Integration tests in "integration_tests.rs"

Also tested with a temporary test package:

~> ../../ruff/target/debug/ruff.exe check --select UP038
warning: Rule `UP038` is deprecated and will be removed in a future release.
warning: Detected debug build without --no-cache.
UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
 --> main.py:2:11
  |
1 | def main():
2 |     print(isinstance(25, (str, int)))
  |           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
help: Convert to `X | Y`

Found 1 error.
No fixes available (1 hidden fix can be enabled with the `--unsafe-fixes` option).

~> ../../ruff/target/debug/ruff.exe check --select UP03
warning: Detected debug build without --no-cache.
All checks passed!

~> ../../ruff/target/debug/ruff.exe check --select UP0
warning: Detected debug build without --no-cache.
All checks passed!

~> ../../ruff/target/debug/ruff.exe check --select UP
warning: Detected debug build without --no-cache.
All checks passed!

~> ../../ruff/target/debug/ruff.exe check --select ALL
# warnings and errors, but because of other errors, UP038 was deselected

ntBre pushed a commit that referenced this pull request

Sep 10, 2025

Summary

Closes #18349

After this change:

All deprecated rules are deselected by default
They are only selected if the user specifically selects them by code, e.g. --select UP038
Thus, --select ALL --select UP --select UP0 won't select the deprecated rule UP038
Documented the change in version policy. From now on, deprecating a rule should increase the minor version

Test Plan

Integration tests in "integration_tests.rs"

Also tested with a temporary test package:

~> ../../ruff/target/debug/ruff.exe check --select UP038
warning: Rule `UP038` is deprecated and will be removed in a future release.
warning: Detected debug build without --no-cache.
UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
 --> main.py:2:11
  |
1 | def main():
2 |     print(isinstance(25, (str, int)))
  |           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
help: Convert to `X | Y`

Found 1 error.
No fixes available (1 hidden fix can be enabled with the `--unsafe-fixes` option).

~> ../../ruff/target/debug/ruff.exe check --select UP03
warning: Detected debug build without --no-cache.
All checks passed!

~> ../../ruff/target/debug/ruff.exe check --select UP0
warning: Detected debug build without --no-cache.
All checks passed!

~> ../../ruff/target/debug/ruff.exe check --select UP
warning: Detected debug build without --no-cache.
All checks passed!

~> ../../ruff/target/debug/ruff.exe check --select ALL
# warnings and errors, but because of other errors, UP038 was deselected

ntBre pushed a commit that referenced this pull request

Sep 10, 2025

Summary

Closes #18349

After this change:

All deprecated rules are deselected by default
They are only selected if the user specifically selects them by code, e.g. --select UP038
Thus, --select ALL --select UP --select UP0 won't select the deprecated rule UP038
Documented the change in version policy. From now on, deprecating a rule should increase the minor version

Test Plan

Integration tests in "integration_tests.rs"

Also tested with a temporary test package:

~> ../../ruff/target/debug/ruff.exe check --select UP038
warning: Rule `UP038` is deprecated and will be removed in a future release.
warning: Detected debug build without --no-cache.
UP038 Use `X | Y` in `isinstance` call instead of `(X, Y)`
 --> main.py:2:11
  |
1 | def main():
2 |     print(isinstance(25, (str, int)))
  |           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
help: Convert to `X | Y`

Found 1 error.
No fixes available (1 hidden fix can be enabled with the `--unsafe-fixes` option).

~> ../../ruff/target/debug/ruff.exe check --select UP03
warning: Detected debug build without --no-cache.
All checks passed!

~> ../../ruff/target/debug/ruff.exe check --select UP0
warning: Detected debug build without --no-cache.
All checks passed!

~> ../../ruff/target/debug/ruff.exe check --select UP
warning: Detected debug build without --no-cache.
All checks passed!

~> ../../ruff/target/debug/ruff.exe check --select ALL
# warnings and errors, but because of other errors, UP038 was deselected

dcreager added a commit that referenced this pull request

Sep 10, 2025

main: (26 commits) Ignore deprecated rules unless selected by exact code (#20167) Stabilize adding future import via config option (#20277) [flake8-errmsg] Stabilize extending raw-string-in-exception (EM101) to support byte strings (#20273) Stabilize the remaining Airflow rules (#20250) [flake8-bugbear] Stabilize support for non-context-manager calls in assert-raises-exception (B017) (#20274) [flake8-commas] Stabilize support for trailing comma checks in type parameter lists (COM812, COM819) (#20275) [pygrep_hooks] Stabilize usingAsyncMock methods in invalid-mock-access (PGH005) (#20272) Stabilize new strategy for classifying imports as first party (#20268) [pylint] Stabilize ignoring __init__.py for useless-import-alias (PLC0414) (#20271) [pylint] Stabilize adding U+061C to bidirectional-unicode (PLE2502) (#20276) [flake8-simplify] Stabilize fix safety of multiple-with-statements (SIM117) (#20270) Stabilize pytest-raises-ambiguous-pattern (RUF043) (#20253) Stabilize f-string-number-format (FURB116) (#20247) [pyupgrade] Remove non-pep604-isinstance (UP038) (#19156) [pandas-vet] Remove pandas-df-variable-name (PD901) (#19223) Remove deprecated macOS config file discovery (#19210) Stabilize redundant-none-literal (PYI061) (#20236) Stabilize generic-not-last-base-class (PYI059) (#20246) Stabilize useless-class-metaclass-type (UP050) (#20230) Stabilize os-symlink (PTH211) (#20229) ...

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})