Semantic tokens: consistently add the DEFINITION modifier by lucach · Pull Request #21521 · astral-sh/ruff (original) (raw)

There are a few more statements potentially containing definitions than what is currently covered. This commit reviews all the statements and completes the list of those requiring a custom visitor to add the DEFINITION modifier for the appropriate tokens.

dcreager added a commit that referenced this pull request

Nov 19, 2025

• origin/main: [ty] Fix flaky tests on macos (#21524) [ty] Add tests for generic implicit type aliases (#21522) [ty] Semantic tokens: consistently add the DEFINITION modifier (#21521) Only render hyperlinks for terminals known to support them (#21519) [ty] Keep colorizing mypy_primer output (#21515) [ty] Exit with 2 if there's any IO error (#21508) [ruff] Fix false positive for complex conversion specifiers in logging-eager-conversion (RUF065) (#21464) [ty] tighten up handling of subscripts in type expressions (#21503)

dcreager added a commit that referenced this pull request

Nov 19, 2025

• origin/main: [ty] Fix flaky tests on macos (#21524) [ty] Add tests for generic implicit type aliases (#21522) [ty] Semantic tokens: consistently add the DEFINITION modifier (#21521) Only render hyperlinks for terminals known to support them (#21519) [ty] Keep colorizing mypy_primer output (#21515) [ty] Exit with 2 if there's any IO error (#21508) [ruff] Fix false positive for complex conversion specifiers in logging-eager-conversion (RUF065) (#21464) [ty] tighten up handling of subscripts in type expressions (#21503)

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})