[ty] Avoid duplicate syntax errors for await outside functions by ntBre · Pull Request #22826 · astral-sh/ruff (original) (raw)
Summary
This PR fixes astral-sh/ty#2598 by not emitting the YieldOutsideFunction
syntax error for await expressions outside of functions. This isn't the most
elegant fix, but as I noted in the TODO comment, I think a better long-term fix
like not emitting YieldOutsideFunction errors for await at all would change
the behavior of Ruff's stable F704 lint rule. We should be able to fix that
and this TODO when resolving #19122.
Test Plan
We already had an existing mdtest for this behavior, so I just had to update it to remove the less specific error message
Multi-file analysis & type inference
label
ntBre deleted the brent/duplicate-async-errors branch
carljm added a commit that referenced this pull request
- main: (62 commits)
[
refurb] Do not addabc.ABCif already present (FURB180) (#22234) [ty] Add a newassert-type-unspellable-subtypediagnostic (#22815) [ty] Avoid duplicate syntax errors forawaitoutside functions (#22826) [ty] Fix unary operator false-positive for constrained TypeVars (#22783) [ty] Fix binary operator false-positive for constrained TypeVars (#22782) [ty] Fix false-positiveunsupported-operatorfor "symmetric" TypeVars (#22756) [pydocstyle] Clarify which quote styles are allowed (D300) (#22825) [ty] Use distributed versions of AND and OR on constraint sets (#22614) [ty] Add support for dict literals and dict() calls as default values for parameters with TypedDict types (#22161) Document-stdin convention in CLI help text (#22817) [ty] Makeinfer_subscript_expression_typesa method onType(#22731) [ty] SimplifyOverloadLiteral::spansandOverloadLiteral::parameter_span(#22823) [ty] Require both*argsand**kwargswhen calling aParamSpeccallable (#22820) [ty] Handle tagged errors in conformance (#22746) Add--colorcli option to force colored output (#22806) Identify notebooks by LSP didOpen instead of.ipynbfile extension (#22810) [ty] Fix docstring rendering for literal blocks after doctests (#22676) [ty] Update salsa to fix out-of-order query validation (#22498) [ty] Inline cycle initial and recovery functions (#22814) [ty] Pass the generic context through the decorator (#22544) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})