Updates to handle new pylint requirements by mattsb42-aws · Pull Request #196 · aws/aws-encryption-sdk-python (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits6 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Description of changes:
Recent pylint releases added some additional checks.
These changes handle those appropriately.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable:
- Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.
attrs==19.2.0 removed a deprecated feature that aws-encryption-sdk==1.3.3 depended on. This reorganization lets us define specific requirements bounds for old versions of aws-encryption-sdk that will probably continue to be necessary as these old versions age.
| @@ -0,0 +1,2 @@ |
|---|
| aws-encryption-sdk==1.3.3 |
| attrs<19.2.0 |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we add a version for attrs here?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bah...didn't expand the comment :(
attrs==19.2.0 removed a deprecated feature that aws-encryption-sdk==1.3.3 depended on.
This reorganization lets us define specific requirements bounds for old versions of aws-encryption-sdk
that will probably continue to be necessary as these old versions age.
mattsb42-aws added a commit that referenced this pull request
Update PR template
Added a check for max_age being greater than 0 (#172)
Added a check for max_age being greater than 0
Fixed flake8 by adding missing pydocstyle dependency
Added the dependency to decrypt_oracle as well
Added test for max_age<=0 ValueError
Updated test for max_age<=0.0 ValueError
Added negative test case
Fixed KMS master key provider tests when default AWS region is configured (#179)
Fixed KMS master key provider tests for users who have their default AWS region configured
created fixture for botocore session with no region set
add auto-used fixture in KMS master key provider unit tests to test against both with and without default region
Wrote example and test for using one kms cmk with an unsigned algorithm
Update one_kms_cmk_unsigned.py
Update examples/src/one_kms_cmk_unsigned.py
Co-Authored-By: Matt Bullock bullocm@amazon.com
isort-check now succeeds
[issue-190] Regional clients modify default botocore session (#193)
[issue-190] Creation of regional clients modifies default botocore session's region
update changelog with changes for 1.4.1 release
bump version to 1.4.1
Updates to handle new pylint requirements (#196)
pylint max-attributes appears to be ratcheted down recently
remove unnecessary comprehensions
whitelist some pylint use-constant-test false-positives
reorganize backwards compatibility test requirements definitions attrs==19.2.0 removed a deprecated feature that aws-encryption-sdk==1.3.3 depended on. This reorganization lets us define specific requirements bounds for old versions of aws-encryption-sdk that will probably continue to be necessary as these old versions age.
remove unnecessary comprehensions
add newlines to the end of all requirements files
help pylint ignore mypy type use
2 participants
