forbid H264 packetization mode zero by aler9 · Pull Request #1072 · bluenviron/gortsplib (original) (raw)
Conversation
•
edited
Loading
Copy link Copy Markdown
Member
Packetization mode zero requires allowing inefficient and brittle fragmented UDP packets, which we are not.
`[forbid H264 packetization mode zero](/bluenviron/gortsplib/pull/1072/commits/93ff791627a65a45a3897327c5a668ec14d10e68 "forbid H264 packetization mode zero
Packetization mode zero requires allowing fragmented UDP packets, which we are not doing.") `
[93ff791](/bluenviron/gortsplib/pull/1072/commits/93ff791627a65a45a3897327c5a668ec14d10e68)
Packetization mode zero requires allowing fragmented UDP packets, which we are not doing.
codecov Bot commented
Copy link Copy Markdown
Codecov Report
❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.83%. Comparing base (aec6282) to head (93ff791).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| pkg/format/rtph264/decoder.go | 0.00% | 1 Missing and 1 partial ⚠️ |
| pkg/format/rtph264/encoder.go | 0.00% | 1 Missing and 1 partial ⚠️ |
Additional details and impacted files
@@ Coverage Diff @@ ## main #1072 +/- ##
Coverage 82.83% 82.83%
Files 129 129
Lines 12024 12024
Hits 9960 9960
Misses 1508 1508
Partials 556 556
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
7 of 8 checks passed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
1 participant
