SRT PeerIdleTimeout follows MTX readTimeout by jmduerk · Pull Request #5489 · bluenviron/mediamtx (original) (raw)
Conversation
This PR would address issue #5428 by assigning the default SRT PeerIdleTimeout to mimic MediaMTX's configured readTimeout alongside ConnectionTimeout. The upstream gosrt library uses 2s, which severely limits SRT's effectiveness in the lossy environments it was designed to work in. Mimicking readTimeout is an elegant way to address the issue since PeerIdleTimeout is virtually a reader timeout with regards to SRT.
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.69%. Comparing base (87fbfeb) to head (4b56b9e).
⚠️ Report is 2 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@ ## main #5489 +/- ##
Coverage 59.70% 59.69% -0.02%
Files 192 192
Lines 16306 16307 +1- Hits 9736 9734 -2
- Misses 5716 5719 +3
Partials 854 854
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
This issue is mentioned in release v1.16.2 🚀
Check out the entire changelog by clicking here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
2 participants
