fix(privacy): Shred private WKWebsiteDataStore data types by StephenHeaps · Pull Request #26199 · brave/brave-core (original) (raw)
- Add some of the private
WKWebsiteDataStoretypes to Shred.
Resolves brave/brave-browser#41863
Submitter Checklist:
- I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
- There is a ticket for my issue
- Used Github auto-closing keywords in the PR description above
- Wrote a good PR/commit description
- Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
- Added appropriate labels (
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issue - Checked the PR locally:
- Ran
git rebase master(if needed)
Reviewer Checklist:
- A security review is not needed, or a link to one is included in the PR description
- New files have MPL-2.0 license header
- Adequate test coverage exists to prevent regressions
- Major classes, functions and non-trivial code blocks are well-commented
- Changes in component dependencies are properly reflected in
gn - Code follows the style guide
- Test plan is specified in PR before merging
After-merge Checklist:
- The associated issue milestone is set to the smallest version that the
changes has landed on - All relevant documentation has been updated, for instance:
- https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
- https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
- https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
- https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
- https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
- https://github.com/brave/brave-browser/wiki/QA-Guide
- https://github.com/brave/brave-browser/wiki/P3A
Test Plan:
| // https://github.com/WebKit/WebKit/blob/b66e4895df40202b14bb20fb47444c3e0a3c164e/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataRecordPrivate.h |
|---|
| var types = WKWebsiteDataStore.allWebsiteDataTypes() |
| types.insert("_WKWebsiteDataTypeHSTSCache") |
| types.insert("_WKWebsiteDataTypeMediaKeys") |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| types.insert("_WKWebsiteDataTypeAdClickAttributions") |
|---|
| types.insert("_WKWebsiteDataTypePrivateClickMeasurements") |
| types.insert("_WKWebsiteDataTypeAlternativeServices") |
| return types |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you want to also include _WKWebsiteDataTypeFileSystem and _WKWebsiteDataTypeSearchFieldRecentSearches for users not on iOS 17?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was referenced
Oct 24, 2024
kjozwiak pushed a commit that referenced this pull request
kjozwiak pushed a commit that referenced this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})