Fixed regressions: #163 and #194 by belingueres · Pull Request #195 · codehaus-plexus/plexus-utils (original) (raw)

Skip to content

Navigation Menu

Sign in

Appearance settings

• • AI CODE CREATION
    * GitHub CopilotWrite better code with AI
    * GitHub Copilot appDirect agents from issue to merge
    * MCP RegistryNewIntegrate external tools
  • DEVELOPER WORKFLOWS
    * ActionsAutomate any workflow
    * CodespacesInstant dev environments
    * IssuesPlan and track work
    * Code ReviewManage code changes
  • APPLICATION SECURITY
    * GitHub Advanced SecurityFind and fix vulnerabilities
    * Code securitySecure your code as you build
    * Secret protectionStop leaks before they start
  • EXPLORE
    * Why GitHub
    * Documentation
    * Blog
    * Changelog
    * Marketplace

View all features

• • BY COMPANY SIZE
    * Enterprises
    * Small and medium teams
    * Startups
    * Nonprofits
  • BY USE CASE
    * App Modernization
    * DevSecOps
    * DevOps
    * CI/CD
    * View all use cases
  • BY INDUSTRY
    * Healthcare
    * Financial services
    * Manufacturing
    * Government
    * View all industries

View all solutions

• • EXPLORE BY TOPIC
    * AI
    * Software Development
    * DevOps
    * Security
    * View all topics
  • EXPLORE BY TYPE
    * Customer stories
    * Events & webinars
    * Ebooks & reports
    * Business insights
    * GitHub Skills
  • SUPPORT & SERVICES
    * Documentation
    * Customer support
    * Community forum
    * Trust center
    * Partners

View all resources

• • COMMUNITY
    * GitHub SponsorsFund open source developers
  • PROGRAMS
    * Security Lab
    * Maintainer Community
    * Accelerator
    * GitHub Stars
    * Archive Program
  • REPOSITORIES
    * Topics
    * Trending
    * Collections
• • ENTERPRISE SOLUTIONS
    * Enterprise platformAI-powered developer platform
  • AVAILABLE ADD-ONS
    * GitHub Advanced SecurityEnterprise-grade security features
    * Copilot for BusinessEnterprise-grade AI features
    * Premium SupportEnterprise-grade 24/7 support
• Pricing

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

codehaus-plexus / plexus-utils Public

• Notifications You must be signed in to change notification settings

• Fork48

• Star 39

• Code

• Issues 5

• Pull requests 3

• Discussions

• Actions

• Security and quality

• Insights

Additional navigation options

Merged

michael-o

merged 1 commit into

codehaus-plexus:masterfrom

belingueres:ISSUE-194-AND-163

Apr 16, 2022

ConversationCommits (1)ChecksFiles changed

Merged

Fixed regressions: #163 and #194#195

michael-o

merged 1 commit into

codehaus-plexus:masterfrom

belingueres:ISSUE-194-AND-163

Conversation

belingueres commented

Apr 5, 2022

Copy link Copy Markdown

Contributor

• Regression: encoding error when parsing a ISO-8859-1 pom with Maven Resolver #163 - new case: Don't assume UTF8 as default, to allow parsing from String.
• Incorrect getText() after parsing the DOCDECL section #194 - Incorrect getText() after parsing the DOCDECL section.

[](/apps/sonatype-lift)

sonatype-lift Bot reviewed Apr 5, 2022

View reviewed changes

Comment thread

src/main/java/org/codehaus/plexus/util/xml/pull/MXParser.java Outdated

[](/apps/sonatype-lift)

sonatype-lift Bot reviewed Apr 5, 2022

View reviewed changes

Comment thread

src/main/java/org/codehaus/plexus/util/xml/pull/MXParser.java Outdated

belingueres force-pushed the ISSUE-194-AND-163 branch from5ff5d58 to48e6445 Compare

April 6, 2022 10:30

belingueres force-pushed the ISSUE-194-AND-163 branch from48e6445 to9dc1610 Compare

April 14, 2022 23:32

[](/apps/sonatype-lift)

sonatype-lift Bot reviewed Apr 14, 2022

View reviewed changes

Comment thread

src/main/java/org/codehaus/plexus/util/xml/pull/MXParser.java

[](/apps/sonatype-lift)

sonatype-lift Bot reviewed Apr 14, 2022

View reviewed changes

Comment thread

src/main/java/org/codehaus/plexus/util/xml/pull/MXParser.java

[](/apps/sonatype-lift)

sonatype-lift Bot reviewed Apr 14, 2022

View reviewed changes

Comment thread

src/main/java/org/codehaus/plexus/util/xml/pull/MXParser.java Outdated

`[Fixed regressions:](/codehaus-plexus/plexus-utils/pull/195/commits/55678b05e04a97384902914968e8c9fb5fab92cf "Fixed regressions:

• #163 - new case: Don't assume UTF8 as default, to allow parsing from String.
• #194 - Incorrect getText() after parsing the DOCDECL section.
• Added tests exercising other regressions exposed while fixing this issues.") `

[55678b0](/codehaus-plexus/plexus-utils/pull/195/commits/55678b05e04a97384902914968e8c9fb5fab92cf)

• codehaus-plexus#163 - new case: Don't assume UTF8 as default, to allow parsing from String.
• codehaus-plexus#194 - Incorrect getText() after parsing the DOCDECL section.
• Added tests exercising other regressions exposed while fixing this issues.

belingueres force-pushed the ISSUE-194-AND-163 branch from9dc1610 to55678b0 Compare

April 15, 2022 01:03

michael-o merged commit b99f7c0 into codehaus-plexus:master

Apr 16, 2022

michael-o mentioned this pull request

Apr 16, 2022

Incorrect getText() after parsing the DOCDECL section#194

Closed

belingueres commented

Apr 17, 2022

Copy link Copy Markdown

Contributor Author

@michael-o Thanks for merging this PR. Unfortunately two of the test files where commited with the wrong git core.autocrlf setting, losing the intended CRLF line endings:
src/test/resources/xml/test-entities-dos.xml
src/test/resources/xml/test-entities-in-attr-dos.xml

michael-o commented

Apr 17, 2022

Copy link Copy Markdown

Member

Please provide a followup PR with gitattributes for these files.

belingueres mentioned this pull request

Apr 17, 2022

Fix some testing XML files checkout with incorrect eol#198

Merged

olamy added the bug label

May 17, 2022

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

sonatype-lift[bot] sonatype-lift[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants