Fix incorrect variable references by mclow · Pull Request #727 · cplusplus/draft (original) (raw)

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

@mclow

Two move operations for the allocators refer to a or a1, though the code uses u. Fix the description to match the code.
Also, change the phrase "equals" to "is equal to", which matches other uses in the standard (see [unique.ptr]/4.1 for an example).

@mclow

Two move operations for the allocators refer to a or a1, though the code uses u. Fix the description to match the code. Also, change the phrase "equals" to "is equal to", which matches other uses in the standard (see [unique.ptr]/4.1 for an example).

zygoloid

post: \tcode{Y(a) == b}, \tcode{a == X(b)} & \\ \rowsep
\tcode{X u(std::move(a));} \br
\tcode{X u = std::move(a);} &

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also fix the two similar cases above (X u = a; and X u(b);)?

FrankHB pushed a commit to FrankHB/draft that referenced this pull request

Jul 9, 2016

@mclow @FrankHB

…#727)

Two move operations for the allocators refer to a or a1, though the code uses u. Fix the description to match the code. Also, change the phrase "equals" to "is equal to", which matches other uses in the standard (see [unique.ptr]/4.1 for an example).

2 participants

@mclow @zygoloid