[dotnet/msbuild] Create directory in the ILStrip task instead of using MSBuild logic. by rolfbjarne · Pull Request #19181 · dotnet/macios (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation18 Commits3 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

rolfbjarne

@rolfbjarne

@vs-mobiletools-engineering-service2

This comment has been minimized.

dalexsoto

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

haritha-mohan

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne

@rolfbjarne

@vs-mobiletools-engineering-service2

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2

@vs-mobiletools-engineering-service2

@vs-mobiletools-engineering-service2

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 6549a36a7fe1e8435d8d52706b871aa28ccef80e [PR build]

@vs-mobiletools-engineering-service2

mandel-macaque

emaf

emaf approved these changes Oct 16, 2023

@rolfbjarne

/sudo backport release/8.0.1xx

@rolfbjarne

/sudo backport release/8.0.1xx-rc2.1

@vs-mobiletools-engineering-service2

Backport Job to branch release/8.0.1xx Created! The magic is happening here

@vs-mobiletools-engineering-service2

Backport Job to branch release/8.0.1xx-rc2.1 Created! The magic is happening here

@vs-mobiletools-engineering-service2

@vs-mobiletools-engineering-service2

rolfbjarne added a commit that referenced this pull request

Oct 17, 2023

@vs-mobiletools-engineering-service2 @rolfbjarne

…sk instead of using MSBuild logic. (#19226)

The current logic doesn't work on Windows for some reason.

Also avoid extra slash in _StrippedAssemblyDirectory, because DeviceSpecificIntermediateOutputPath already has a trailing slash.

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1864985.

Backport of #19181


Co-authored-by: Rolf Bjarne Kvinge rolf@xamarin.com

rolfbjarne added a commit that referenced this pull request

Oct 17, 2023

@vs-mobiletools-engineering-service2 @rolfbjarne

…rip task instead of using MSBuild logic. (#19225)

The current logic doesn't work on Windows for some reason.

Also avoid extra slash in _StrippedAssemblyDirectory, because DeviceSpecificIntermediateOutputPath already has a trailing slash.

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1864985.

Backport of #19181


Co-authored-by: Rolf Bjarne Kvinge rolf@xamarin.com

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@emaf emaf emaf approved these changes

@haritha-mohan haritha-mohan haritha-mohan approved these changes

@mauroa mauroa Awaiting requested review from mauroa mauroa is a code owner