[msbuild] Look for and copy binding resource packages to the remote Mac in the ResolveNativeReferences task. Fixes #19229. by rolfbjarne · Pull Request #19325 · dotnet/macios (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation9 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

rolfbjarne

Look for any binding resource packages (a directory named AssemblyName.resources
or a compressed version named AssemblyName.resources.zip) next to any references,
and copy those to the remote Mac when doing remote builds.

Fixes #19229.

@rolfbjarne

…ac in the ResolveNativeReferences task. Fixes dotnet#19229.

Look for any binding resource packages (a directory named AssemblyName.resources or a compressed version named AssemblyName.resources.zip) next to any references, and copy those to the remote Mac when doing remote builds.

Fixes dotnet#19229.

@rolfbjarne rolfbjarne added the bug

If an issue is a bug or a pull request a bug fix

label

Oct 24, 2023

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this pull request

Oct 24, 2023

@rolfbjarne

…es to the remote Mac in the ResolveNativeReferences task. Fixes dotnet#19229.

Look for any binding resource packages (a directory named AssemblyName.resources or a compressed version named AssemblyName.resources.zip) next to any references, and copy those to the remote Mac when doing remote builds.

Backport of dotnet#19325.

dalexsoto

mauroa

emaf

emaf approved these changes Oct 24, 2023

tj-devel709

@vs-mobiletools-engineering-service2

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2

@vs-mobiletools-engineering-service2

@vs-mobiletools-engineering-service2

@rolfbjarne

Test failure is unrelated (#19320).

@rolfbjarne rolfbjarne deleted the msbuild-remote-copy-binding-resource-packages branch

October 25, 2023 06:44

@rolfbjarne

/sudo backport release/8.0.1xx

@vs-mobiletools-engineering-service2

Backport Job to branch release/8.0.1xx Created! The magic is happening here

@vs-mobiletools-engineering-service2

dalexsoto pushed a commit that referenced this pull request

Oct 25, 2023

@vs-mobiletools-engineering-service2 @rolfbjarne

…es to the remote Mac in the ResolveNativeReferences task. Fixes #19229. (#19334)

Look for any binding resource packages (a directory named AssemblyName.resources or a compressed version named AssemblyName.resources.zip) next to any references, and copy those to the remote Mac when doing remote builds.

Fixes #19229.

Backport of #19325

Co-authored-by: Rolf Bjarne Kvinge rolf@xamarin.com

dalexsoto pushed a commit that referenced this pull request

Oct 25, 2023

@rolfbjarne

…es to the remote Mac in the ResolveNativeReferences task. Fixes #19229. (#19326)

Look for any binding resource packages (a directory named AssemblyName.resources or a compressed version named AssemblyName.resources.zip) next to any references, and copy those to the remote Mac when doing remote builds.

Backport of #19325.

Labels

bug

If an issue is a bug or a pull request a bug fix