[msbuild] Fix resolving static libraries inside an XCFramework in a NuGet. by rolfbjarne · Pull Request #19502 · dotnet/macios (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation17 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
The ResolveNativeReferences task would incorrectly set Kind=Framework for static
libraries and dylibs if these files came from an XCFramework in the runtimes/native
directory in a NuGet (as opposed to a binding project, or the NuGet built from a
binding project).
Fix this by properly assigning the Kind and PublishFolderType metadata for such static
libraries and dylibs.
Also add a test.
…uGet.
The ResolveNativeReferences task would incorrectly set Kind=Framework for static libraries and dylibs if these files came from an XCFramework in the runtimes/native directory in a NuGet (as opposed to a binding project, or the NuGet built from a binding project).
Fix this by properly assigning the Kind and PublishFolderType metadata for such static libraries and dylibs.
Also add a test.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
emaf approved these changes Nov 21, 2023
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻
✅ All tests on macOS M1 - Mac Ventura (13.0) passed.
Pipeline on Agent
Hash: [PR build]
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻
✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.
Pipeline on Agent
Hash: [PR build]
✅ API diff for current PR / commit
Legacy Xamarin (No breaking changes)
iOS(no change detected)tvOS(no change detected)watchOS(no change detected)macOS(no change detected) NET (empty diffs)iOS: (empty diff detected)tvOS: (empty diff detected)MacCatalyst: (empty diff detected)macOS: (empty diff detected)
✅ API diff vs stable
Legacy Xamarin (No breaking changes)
- iOS: vsdrops gist (No breaking changes)
- tvOS: vsdrops gist (No breaking changes)
- watchOS: vsdrops gist (No breaking changes)
- macOS: vsdrops gist (No breaking changes) .NET (No breaking changes)
- iOS: vsdrops gist (No breaking changes)
- tvOS: vsdrops gist (No breaking changes)
- MacCatalyst: vsdrops gist (No breaking changes)
- macOS: vsdrops gist (No breaking changes)
- Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist Legacy Xamarin (stable) vs .NET
- iOS: vsdrops gist
- tvOS: vsdrops gist
- macOS: vsdrops gist
ℹ️ Generator diff
Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)
Pipeline on Agent
Hash: f7daff34d2c39ed5473be300fd24d4d19100e195 [PR build]
| $(RootTestDirectory)/test-libraries |
|---|
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, use the test too dir var?
/sudo backport release/8.0.1xx
Backport Job to branch release/8.0.1xx Created! The magic is happening here
vs-mobiletools-engineering-service2 added a commit to vs-mobiletools-engineering-service2/xamarin-macios that referenced this pull request
…XCFramework in a NuGet. (dotnet#19523)
The ResolveNativeReferences task would incorrectly set Kind=Framework for static libraries and dylibs if these files came from an XCFramework in the runtimes/native directory in a NuGet (as opposed to a binding project, or the NuGet built from a binding project).
Fix this by properly assigning the Kind and PublishFolderType metadata for such static libraries and dylibs.
Also add a test.
Backport of dotnet#19502
Co-authored-by: Rolf Bjarne Kvinge rolf@xamarin.com