[bgen] Fix assembly comparison. Fixes #19612. by rolfbjarne · Pull Request #19619 · dotnet/macios (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation24 Commits4 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This fixes a regression in .NET 8, where we changed the temporary assembly name when
building using a project file / MSBuild - we started compiling the temporary binding
code in MSBuild instead of in the generator, and in the process we changed the name
of the temporary assembly. This broke logic in bgen that compared the assembly name
to check if a given type is from the temporary assembly or not.

Fix this by checking the actual temporary assembly instead of the name of the assembly
instead.

Fixes #19612.

This fixes a regression in .NET 8, where we changed the temporary assembly name when building using a project file / MSBuild - we started compiling the temporary binding code in MSBuild instead of in the generator, and in the process we changed the name of the temporary assembly. This broke logic in bgen that compared the assembly name to check if a given type is from the temporary assembly or not.

Fix this by checking the actual temporary assembly instead of the name of the assembly instead.

Fixes dotnet#19612.

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

This comment has been minimized.

Comment on lines 376 to 380

public bool IsApiAssembly (Assembly assembly)
{
return assembly == apiAssembly;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this to the Generator class? That way we do not need to call it as BindingTouch.IsApiAssembly, just call the method. Ideally would be nice to be able to have the generator be self-contained and that way be able to unit test things like this.

Would be nice to have the integration tests we have atm + unit tests for this kind of logic.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment has been minimized.

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected) NET (empty diffs)
~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes) .NET (No breaking changes)
iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist Legacy Xamarin (stable) vs .NET
iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 8d68d90537a2edc85c716eff631ada5b4c11dbb4 [PR build]

This comment has been minimized.

/sudo backport release/8.0.1xx

Backport Job to branch release/8.0.1xx Created! The magic is happening here

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this pull request

Dec 14, 2023

This fixes a regression in .NET 8, where we changed the temporary assembly name when building using a project file / MSBuild - we started compiling the temporary binding code in MSBuild instead of in the generator, and in the process we changed the name of the temporary assembly. This broke logic in bgen that compared the assembly name to check if a given type is from the temporary assembly or not.

Fix this by checking the actual temporary assembly instead of the name of the assembly instead.

Fixes dotnet#19612.

Backport of dotnet#19619.

rolfbjarne added a commit that referenced this pull request

Dec 15, 2023

This fixes a regression in .NET 8, where we changed the temporary assembly name when building using a project file / MSBuild - we started compiling the temporary binding code in MSBuild instead of in the generator, and in the process we changed the name of the temporary assembly. This broke logic in bgen that compared the assembly name to check if a given type is from the temporary assembly or not.

Fix this by checking the actual temporary assembly instead of the name of the assembly instead.

Fixes #19612.

Backport of #19619.