[AppKit] Fix binding for NSFontDescriptor.Create. Fixes #19659. by rolfbjarne · Pull Request #19663 · dotnet/macios (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation23 Commits4 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
[NSFontDescriptor fontDescriptorWithDesign:] takes an NSString, not the enum
value, so use BindAs to bind correctly.
Fixes #19659.
[NSFontDescriptor fontDescriptorWithDesign:] takes an NSString, not the enum value, so use BindAs to bind correctly.
Fixes dotnet#19659.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻
✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.
Pipeline on Agent
Hash: [PR build]
💻 [CI Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻
✅ All tests on macOS M1 - Mac Ventura (13.0) passed.
Pipeline on Agent
Hash: [PR build]
✅ API diff for current PR / commit
Legacy Xamarin (No breaking changes)
iOS(no change detected)tvOS(no change detected)watchOS(no change detected)- macOS: vsdrops gist (No breaking changes) .NET (No breaking changes)
iOS: (empty diff detected)tvOS: (empty diff detected)MacCatalyst: (empty diff detected)- macOS: vsdrops gist (No breaking changes)
✅ API diff vs stable
Legacy Xamarin (No breaking changes)
- iOS: vsdrops gist (No breaking changes)
- tvOS: vsdrops gist (No breaking changes)
- watchOS: vsdrops gist (No breaking changes)
- macOS: vsdrops gist (No breaking changes) .NET (No breaking changes)
- iOS: vsdrops gist (No breaking changes)
- tvOS: vsdrops gist (No breaking changes)
- MacCatalyst: vsdrops gist (No breaking changes)
- macOS: vsdrops gist (No breaking changes)
- Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist Legacy Xamarin (stable) vs .NET
- iOS: vsdrops gist
- tvOS: vsdrops gist
- macOS: vsdrops gist
ℹ️ Generator diff
Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)
Pipeline on Agent
Hash: 3f8cd7392478741a1dbf729ddec2b400947d826f [PR build]
/sudo backport release/8.0.1xx
Backport Job to branch release/8.0.1xx Created! The magic is happening here
/sudo backport release/8.0.1xx-xcode15.1
Backport Job to branch release/8.0.1xx-xcode15.1 Created! The magic is happening here
dalexsoto pushed a commit that referenced this pull request
….Create. Fixes #19659. (#19731)
[NSFontDescriptor fontDescriptorWithDesign:] takes an NSString, not the enum value, so use BindAs to bind correctly.
Fixes #19659.
Backport of #19663
Co-authored-by: Rolf Bjarne Kvinge rolf@xamarin.com