[dotnet] Fix detecting if the interpreter is enabled. by rolfbjarne · Pull Request #19812 · dotnet/macios (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation11 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
The canonical property we use for the interpreter is MtouchInterpreter
- and
the interpreter is enabled if MtouchInterpreter
is set to any value (theMtouchInterpreter
value is used to select which assemblies to interpret, the
only way to completely disable the interpreter is to not setMtouchInterpreter
at all).
So fix a couple of cases of wrong comparison:
- Don't use
UseInterpreter
- which is used to compute a specific value forMtouchInterpreter
- because developers don't have to setUseInterpreter
to enable the interpreter, they can setMtouchInterpreter
directly. - Don't compare
MtouchInterpreter
withtrue
: that only checks if the
assembly "true" is interpreted (which it rarely is).
Fixes dotnet/runtime#96920.
The canonical property we use for the interpreter is MtouchInterpreter
- and
the interpreter is enabled if MtouchInterpreter
is set to any value (the
MtouchInterpreter
value is used to select which assemblies to interpret, the
only way to completely disable the interpreter is to not set
MtouchInterpreter
at all).
So fix a couple of cases of wrong comparison:
- Don't use
UseInterpreter
- which is used to compute a specific value forMtouchInterpreter
- because developers don't have to setUseInterpreter
to enable the interpreter, they can setMtouchInterpreter
directly. - Don't compare
MtouchInterpreter
withtrue
: that only checks if the assembly "true" is interpreted (which it rarely is).
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💻 [CI Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻
✅ All tests on macOS M1 - Mac Ventura (13.0) passed.
Pipeline on Agent
Hash: [PR build]
💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻
✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.
Pipeline on Agent
Hash: [PR build]
✅ API diff for current PR / commit
Legacy Xamarin (No breaking changes)
iOS(no change detected)tvOS(no change detected)watchOS(no change detected)macOS(no change detected) NET (empty diffs)iOS: (empty diff detected)tvOS: (empty diff detected)MacCatalyst: (empty diff detected)macOS: (empty diff detected)
✅ API diff vs stable
Legacy Xamarin (No breaking changes)
- iOS: vsdrops gist (No breaking changes)
- tvOS: vsdrops gist (No breaking changes)
- watchOS: vsdrops gist (No breaking changes)
- macOS: vsdrops gist (No breaking changes) .NET (No breaking changes)
- iOS: vsdrops gist (No breaking changes)
- tvOS: vsdrops gist (No breaking changes)
- MacCatalyst: vsdrops gist (No breaking changes)
- macOS: vsdrops gist (No breaking changes)
- Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist Legacy Xamarin (stable) vs .NET
- iOS: vsdrops gist
- tvOS: vsdrops gist
- macOS: vsdrops gist
ℹ️ Generator diff
Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)
Pipeline on Agent
Hash: 993f1cccdf000e601a8d39f50ec9d432301f1c10 [PR build]
This comment has been minimized.
rolfbjarne deleted the msbuild-interpreter-comparison branch
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this pull request
…upported or not. Fixes #dotnet/runtime@101840.
Dynamic code is not supported if the interpreter is not enabled, and the interpreter is not enabled if the MtouchInterpreter property is empty.
This regression was introduced in dotnet#19812.
Fixes dotnet/runtime#101840.
rolfbjarne added a commit that referenced this pull request
…upported or not. Fixes #dotnet/runtime@101840. (#20563)
Dynamic code is not supported if the interpreter is not enabled, and the interpreter is not enabled if the MtouchInterpreter property is empty.
This regression was introduced in #19812.
Fixes dotnet/runtime#101840.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this pull request
…or not. Fixes #dotnet/runtime@101840. (dotnet#20563)
Dynamic code is not supported if the interpreter is not enabled, and the interpreter is not enabled if the MtouchInterpreter property is empty.
This regression was introduced in dotnet#19812.
Fixes dotnet/runtime#101840.
rolfbjarne added a commit that referenced this pull request
…or not. Fixes #dotnet/runtime@101840. (#20563) (#20696)
Dynamic code is not supported if the interpreter is not enabled, and the interpreter is not enabled if the MtouchInterpreter property is empty.
This regression was introduced in #19812.
Fixes dotnet/runtime#101840.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this pull request
The canonical property we use for the interpreter is MtouchInterpreter
- and
the interpreter is enabled if MtouchInterpreter
is set to any value (the
MtouchInterpreter
value is used to select which assemblies to interpret, the
only way to completely disable the interpreter is to not set
MtouchInterpreter
at all).
So fix a couple of cases of wrong comparison:
- Don't use
UseInterpreter
- which is used to compute a specific value forMtouchInterpreter
- because developers don't have to setUseInterpreter
to enable the interpreter, they can setMtouchInterpreter
directly. - Don't compare
MtouchInterpreter
withtrue
: that only checks if the assembly "true" is interpreted (which it rarely is).
Fixes dotnet/runtime#96920.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this pull request
…or not. Fixes #dotnet/runtime@101840. (dotnet#20563) (dotnet#20696)
Dynamic code is not supported if the interpreter is not enabled, and the interpreter is not enabled if the MtouchInterpreter property is empty.
This regression was introduced in dotnet#19812.
Fixes dotnet/runtime#101840.
rolfbjarne added a commit that referenced this pull request
… is enabled. (#20732)
The canonical property we use for the interpreter is MtouchInterpreter
- and
the interpreter is enabled if MtouchInterpreter
is set to any value (the
MtouchInterpreter
value is used to select which assemblies to interpret, the
only way to completely disable the interpreter is to not set
MtouchInterpreter
at all).
So fix a couple of cases of wrong comparison:
- Don't use
UseInterpreter
- which is used to compute a specific value forMtouchInterpreter
- because developers don't have to setUseInterpreter
to enable the interpreter, they can setMtouchInterpreter
directly. - Don't compare
MtouchInterpreter
withtrue
: that only checks if the assembly "true" is interpreted (which it rarely is).
Fixes dotnet/runtime#96920.