Switch Entry and Editor from EditText to AppCompatEditText by rogihee · Pull Request #493 · dotnet/maui (original) (raw)

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

rogihee

Description of Change

Switches Android handlers for Entry and Editor from EditText to AppCompatEditText. Fixes #466.

Also, a small inconsistent parameter name in iOS was changed ("editText" -> "textField").

Additions made

PR Checklist

@mattleibow

@azure-pipelines

Azure Pipelines successfully started running 1 pipeline(s).

mattleibow

@mattleibow

myroot added a commit to myroot/maui that referenced this pull request

Aug 24, 2022

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 kangho.hur@samsung.com

This reverts commit c54ac83.

This commit will be revert when upstream code is updated

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 kangho.hur@samsung.com

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 kangho.hur@samsung.com

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 kangho.hur@samsung.com

Co-authored-by: Jay Cho chojoong@gmail.com

Co-authored-by: Jay Cho chojoong@gmail.com

Co-authored-by: Jay Cho chojoong@gmail.com

Co-authored-by: Kangho Hur kangho.hur@samsung.com Co-authored-by: 조중현/Common Platform Lab(SR)/Engineer/삼성전자 jh5.cho@samsung.com Co-authored-by: 김성수/Common Platform Lab(SR)/Staff Engineer/삼성전자 sung-su.kim@samsung.com Co-authored-by: 박인서/Common Platform Lab(SR)/Associate/삼성전자 inseo9.park@samsung.com Co-authored-by: 민성현/Common Platform Lab(SR)/Staff Engineer/삼성전자 shyun.min@samsung.com Co-authored-by: Jay Cho chojoong@gmail.com

myroot added a commit to myroot/maui that referenced this pull request

Aug 24, 2022

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 kangho.hur@samsung.com

This reverts commit c54ac83.

This commit will be revert when upstream code is updated

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 kangho.hur@samsung.com

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 kangho.hur@samsung.com

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 kangho.hur@samsung.com

Co-authored-by: Jay Cho chojoong@gmail.com

Co-authored-by: Jay Cho chojoong@gmail.com

Co-authored-by: Jay Cho chojoong@gmail.com

Co-authored-by: Kangho Hur kangho.hur@samsung.com Co-authored-by: 조중현/Common Platform Lab(SR)/Engineer/삼성전자 jh5.cho@samsung.com Co-authored-by: 김성수/Common Platform Lab(SR)/Staff Engineer/삼성전자 sung-su.kim@samsung.com Co-authored-by: 박인서/Common Platform Lab(SR)/Associate/삼성전자 inseo9.park@samsung.com Co-authored-by: 민성현/Common Platform Lab(SR)/Staff Engineer/삼성전자 shyun.min@samsung.com Co-authored-by: Jay Cho chojoong@gmail.com

myroot added a commit to myroot/maui that referenced this pull request

Aug 24, 2022

@myroot

myroot added a commit to myroot/maui that referenced this pull request

Aug 25, 2022

@myroot

rmarinho pushed a commit that referenced this pull request

Aug 26, 2022

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 kangho.hur@samsung.com

This reverts commit c54ac83.

This commit will be revert when upstream code is updated

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 kangho.hur@samsung.com

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 kangho.hur@samsung.com

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 kangho.hur@samsung.com

Co-authored-by: Jay Cho chojoong@gmail.com

Co-authored-by: Jay Cho chojoong@gmail.com

Co-authored-by: Jay Cho chojoong@gmail.com

Co-authored-by: Kangho Hur kangho.hur@samsung.com Co-authored-by: 조중현/Common Platform Lab(SR)/Engineer/삼성전자 jh5.cho@samsung.com Co-authored-by: 김성수/Common Platform Lab(SR)/Staff Engineer/삼성전자 sung-su.kim@samsung.com Co-authored-by: 박인서/Common Platform Lab(SR)/Associate/삼성전자 inseo9.park@samsung.com Co-authored-by: 민성현/Common Platform Lab(SR)/Staff Engineer/삼성전자 shyun.min@samsung.com Co-authored-by: Jay Cho chojoong@gmail.com

Co-authored-by: Kangho Hur kangho.hur@samsung.com Co-authored-by: 조중현/Common Platform Lab(SR)/Engineer/삼성전자 jh5.cho@samsung.com Co-authored-by: 김성수/Common Platform Lab(SR)/Staff Engineer/삼성전자 sung-su.kim@samsung.com Co-authored-by: 박인서/Common Platform Lab(SR)/Associate/삼성전자 inseo9.park@samsung.com Co-authored-by: 민성현/Common Platform Lab(SR)/Staff Engineer/삼성전자 shyun.min@samsung.com Co-authored-by: Jay Cho chojoong@gmail.com

rmarinho pushed a commit that referenced this pull request

Aug 26, 2022

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 kangho.hur@samsung.com

This reverts commit c54ac83.

This commit will be revert when upstream code is updated

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 kangho.hur@samsung.com

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 kangho.hur@samsung.com

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 kangho.hur@samsung.com

Co-authored-by: Jay Cho chojoong@gmail.com

Co-authored-by: Jay Cho chojoong@gmail.com

Co-authored-by: Jay Cho chojoong@gmail.com

Co-authored-by: Kangho Hur kangho.hur@samsung.com Co-authored-by: 조중현/Common Platform Lab(SR)/Engineer/삼성전자 jh5.cho@samsung.com Co-authored-by: 김성수/Common Platform Lab(SR)/Staff Engineer/삼성전자 sung-su.kim@samsung.com Co-authored-by: 박인서/Common Platform Lab(SR)/Associate/삼성전자 inseo9.park@samsung.com Co-authored-by: 민성현/Common Platform Lab(SR)/Staff Engineer/삼성전자 shyun.min@samsung.com Co-authored-by: Jay Cho chojoong@gmail.com