Allow allocating large object from free list while background sweeping SOH by cshung · Pull Request #2103 · dotnet/runtime (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits2 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Fixes #1848

The change postponed the clearing of the free lists of the large object heap, that allows the free list to be used while the background small object heap sweeping is in progress.

Stress tests involving large object allocation mixed with all the existing test cases survived the stress run over the weekend without crashing or deadlock.

@Maoni0 is added to the review. #Closed

these 2 lines can be gotten rid of

Refers to: src/coreclr/src/gc/gc.cpp:34466 in c25b551. [](commit_id = c25b551, deletion_comment = False)

hmm, too bad the lines didn't actually get displayed (just the line #) but if you open this in codeflow it should work

cshung changed the title~~[WIP] Allow allocating large object from free list while background sweeping SOH~~ Allow allocating large object from free list while background sweeping SOH

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cshung deleted the dev/andrewau/keep-loh-freelist branch

January 28, 2020 02:08

VSadov added a commit to VSadov/runtime that referenced this pull request

VSadov added a commit that referenced this pull request

refactoring
ploh-->uoh
fix Linux build PR feedback
some PR feedback
more PR feedback

more PR feedback

more PR feedback
address comments in UpdatePreGCCounters
removed a confusing comment
stress fix in background sweep
use saved_sweep_ephemeral_seg in background sweep.
fixed GCPerHeapHistory_V3 event.
re-implemented #2103 on top of refactoring (it was hard to merge)

MichalStrehovsky pushed a commit to MichalStrehovsky/corert that referenced this pull request

refactoring
ploh-->uoh
fix Linux build PR feedback
some PR feedback
more PR feedback

more PR feedback

more PR feedback
address comments in UpdatePreGCCounters
removed a confusing comment
stress fix in background sweep
use saved_sweep_ephemeral_seg in background sweep.
fixed GCPerHeapHistory_V3 event.
re-implemented dotnet/runtime#2103 on top of refactoring (it was hard to merge)

MichalStrehovsky pushed a commit to MichalStrehovsky/corert that referenced this pull request

refactoring
ploh-->uoh
fix Linux build PR feedback
some PR feedback
more PR feedback

more PR feedback

more PR feedback
address comments in UpdatePreGCCounters
removed a confusing comment
stress fix in background sweep
use saved_sweep_ephemeral_seg in background sweep.
fixed GCPerHeapHistory_V3 event.
re-implemented dotnet/runtime#2103 on top of refactoring (it was hard to merge)

jkotas pushed a commit to dotnet/corert that referenced this pull request

refactoring
ploh-->uoh
fix Linux build PR feedback
some PR feedback
more PR feedback

more PR feedback

more PR feedback
address comments in UpdatePreGCCounters
removed a confusing comment
stress fix in background sweep
use saved_sweep_ephemeral_seg in background sweep.
fixed GCPerHeapHistory_V3 event.
re-implemented dotnet/runtime#2103 on top of refactoring (it was hard to merge)

@ghost ghost locked as resolved and limited conversation to collaborators