Fix createdump DAC segfault by mikem8361 · Pull Request #29892 · dotnet/runtime (original) (raw)

kouvel added a commit that referenced this pull request

Commit 1
- Reverts commit f954c6b, which reverted PR #1457 due to issues
Commit 2
- Fixes crashes and assertion failures seen by the original change, fixes #29934
- The crashes were caused by commit 6aa3c70 in the original PR
- Call counting infos cannot be deleted when the corresponding call counting stubs may still run, because:
  - The remaining call count decremented by the stub is in the call counting info
  - The only way to get a code version / method desc from a stub is to go through the call counting info
- Got one repro of the assertion failure in #22786 and it is most likely caused by the same issue, following heap corruption from modifying a deleted call counting info where the memory is reused for a NativeCodeVersionNode, messing up the method desc pointer
- Fixed with a partial revert of the above commit. Added back the Complete stage and then call counting infos are deleted only after it's ensured that call counting stubs won't be used (shortly before deleting them).
Commit 3
- Public static functions of CallCountingManager that may be called through the debugger may occur before static initialization, added a check for null as suggested in #29892