Fix named cgroup handling in docker by janvorli · Pull Request #980 · dotnet/runtime (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation0 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
While named cgroups work fine outside of docker container, they weren't
working when created and used inside of a docker container. The problem
was caused by the fact that the hierarchy root extracted from
/proc/self/mountinfo and the cgroup path extracted from /proc/self/cgroup
are not equal for named groups. They just share the same prefix.
The cgroups handling code was not epxecting this case and ended up building
the final cgroup path incorrectly (including the common part of the path).
This change fixes it by checking for matching prefix of the paths instead
of comparing the whole paths.
Close #850
While named cgroups work fine outside of docker container, they weren't working when created and used inside of a docker container. The problem was caused by the fact that the hierarchy root extracted from /proc/self/mountinfo and the cgroup path extracted from /proc/self/cgroup are not equal for named groups. They just share the same prefix. The cgroups handling code was not epxecting this case and ended up building the final cgroup path incorrectly (including the common part of the path). This change fixes it by checking for matching prefix of the paths instead of comparing the whole paths.
omajid added a commit to omajid/dotnet-runtime that referenced this pull request
This commit brings in two changes from coreclr to libraries:
-
"Fix named cgroup handling in docker"
This fixes getting cgroup information for named cgroups inside containers.
-
"Add cgroup v2 support to coreclr"
This is essentially the same change pushed to corefx (now libraries) to add cgroupv2 support, but this newer coreclr change has one major difference: it determines whether the system is using cgroup v1 or cgroup v2 once, and then explicitly uses that (only). This avoids issues on systems where both cgroup v1 and v2 are enabled, (but only one is being used by default).
stephentoub pushed a commit that referenced this pull request
This commit brings in two changes from coreclr to libraries:
-
"Fix named cgroup handling in docker"
This fixes getting cgroup information for named cgroups inside containers.
-
"Add cgroup v2 support to coreclr"
This is essentially the same change pushed to corefx (now libraries) to add cgroupv2 support, but this newer coreclr change has one major difference: it determines whether the system is using cgroup v1 or cgroup v2 once, and then explicitly uses that (only). This avoids issues on systems where both cgroup v1 and v2 are enabled, (but only one is being used by default).
