Remove sourcelink dependency by NikolaMilosavljevic · Pull Request #1084 · dotnet/sourcelink (original) (raw)

Skip to content

Sign in

Appearance settings

View all features

View all solutions

View all resources

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

dotnet / sourcelink Public

Additional navigation options

Merged

tmat

merged 1 commit into

dotnet:mainfrom

NikolaMilosavljevic:sourcelink.remove

Aug 15, 2023

ConversationCommits (1)ChecksFiles changed

Merged

Remove sourcelink dependency#1084

tmat

merged 1 commit into

dotnet:mainfrom

NikolaMilosavljevic:sourcelink.remove

Conversation

@NikolaMilosavljevic

@NikolaMilosavljevic NikolaMilosavljevic commented

Aug 15, 2023

Copy link Copy Markdown

Member

Contributes to dotnet/source-build#3551

Sourcelink dependency isn't needed anymore. Arcade uses sourcelink tooling that is included in .NET SDK 8.0 preview 6.

@NikolaMilosavljevic

[Remove sourcelink dependency](/dotnet/sourcelink/pull/1084/commits/3827373da0bf889ceb4173146275abc69dbe7a35 "Remove sourcelink dependency")

[3827373](/dotnet/sourcelink/pull/1084/commits/3827373da0bf889ceb4173146275abc69dbe7a35)

@NikolaMilosavljevic

NikolaMilosavljevic commented

Aug 15, 2023

Copy link Copy Markdown

Member Author

@tmat @mmitche @MichaelSimons

MichaelSimons

MichaelSimons approved these changes Aug 15, 2023

View reviewed changes

@tmat tmat merged commit bf63e72 into dotnet:main

Aug 15, 2023

@NikolaMilosavljevic NikolaMilosavljevic mentioned this pull request

Aug 15, 2023

Clean up sourcebuild tags in sourcelink dependenciesdotnet/source-build#3551

Closed

20 tasks

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@MichaelSimons MichaelSimons MichaelSimons approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NikolaMilosavljevic @MichaelSimons @tmat