Update to Unified Build controls by mmitche · Pull Request #1194 · dotnet/sourcelink (original) (raw)

Skip to content

Sign in

Appearance settings

View all features

View all solutions

View all resources

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

dotnet / sourcelink Public

Additional navigation options

Merged

ViktorHofer

merged 1 commit into

dotnet:mainfrom

mmitche:update-sb-controls

Feb 1, 2024

ConversationCommits (1)ChecksFiles changed

Merged

Update to Unified Build controls#1194

ViktorHofer

merged 1 commit into

dotnet:mainfrom

mmitche:update-sb-controls

Conversation

@mmitche

@mmitche mmitche commented

Jan 31, 2024

Copy link Copy Markdown

Member

No description provided.

@mmitche

[Update to Unified Build controls](/dotnet/sourcelink/pull/1194/commits/5fade124c06580dbd5410e05b7602bffa870c2ac "Update to Unified Build controls")

[5fade12](/dotnet/sourcelink/pull/1194/commits/5fade124c06580dbd5410e05b7602bffa870c2ac)

@mmitche mmitche requested a review from ViktorHofer

January 31, 2024 23:14

@mmitche mmitche mentioned this pull request

Jan 31, 2024

Unified Build control update#866

Closed

@mmitche

mmitche commented

Jan 31, 2024

Copy link Copy Markdown

Member Author

Hold while I verify

ViktorHofer

ViktorHofer approved these changes Feb 1, 2024

View reviewed changes

@ViktorHofer ViktorHofer left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure, does this require a re-bootstrap in the VMR?

@mmitche

mmitche commented

Feb 1, 2024

Copy link Copy Markdown

Member Author

Sourcelink is after arcade, so no.

ViktorHofer reacted with thumbs up emoji

@ViktorHofer ViktorHofer merged commit 006ca8c into dotnet:main

Feb 1, 2024

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmitche @ViktorHofer