PaginationSerializer hardcoded to use ListSerializer · Issue #2327 · encode/django-rest-framework (original) (raw)

Skip to content

Navigation Menu

• • GitHub Copilot Write better code with AI
  • GitHub Advanced Security Find and fix vulnerabilities
  • Actions Automate any workflow
  • Codespaces Instant dev environments
  • Issues Plan and track work
  • Code Review Manage code changes
  • Discussions Collaborate outside of code
  • Code Search Find more, search less
• Explore
  • Learning Pathways
  • Events & Webinars
  • Ebooks & Whitepapers
  • Customer Stories
  • Partners
  • Executive Insights
• • GitHub Sponsors Fund open source developers
  • The ReadME Project GitHub community articles
• • Enterprise platform AI-powered developer platform
• Pricing

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Description

To me it feels like it should use Meta.list_serializer_class of the object serializer if it is defined instead.

diff --git a/rest_framework/pagination.py b/rest_framework/pagination.py index fb45128..94c2f2d 100644 --- a/rest_framework/pagination.py +++ b/rest_framework/pagination.py @@ -68,7 +68,12 @@ class BasePaginationSerializer(serializers.Serializer): except AttributeError: object_serializer = DefaultObjectSerializer

•    self.fields[results_field] = serializers.ListSerializer(

•    try:

•        list_serializer = object_serializer.Meta.list_serializer_class

•    except AttributeError:

•        list_serializer = serializers.ListSerializer

•    self.fields[results_field] = list_serializer(
         child=object_serializer(),
         source='object_list'
     )