Rationalize File timestamp callback by earlephilhower · Pull Request #7785 · esp8266/Arduino (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits3 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

earlephilhower

Fixes #7775

Clean up the passing/setting of custom File time callbacks and add a
host test verifying they work. Existing core was not passing custom
timeCallbacks set at the FS level down to open()ed files, resulting in
them calling the default time(nullptr) and reporting wrong file modify
times.

@earlephilhower

Fixes esp8266#7775

Clean up the passing/setting of custom File time callbacks and add a host test verifying they work. Existing core was not passing custom timeCallbacks set at the FS level down to open()ed files, resulting in them calling the default time(nullptr) and reporting wrong file modify times.

@earlephilhower

@alka79 can you please give this a try and report back?

@alka79

@alka79 can you please give this a try and report back?

with pleasure, but I don't know how to get the test version. I am no using git and not familiar with github. If you can point me to the package to download, I'll give it a try asap.

@d-a-v

d-a-v

@d-a-v

@earlephilhower

@alka79

just tested. Looks good to me :)
thanks for the quick fix.

davisonja added a commit to davisonja/Arduino that referenced this pull request

Dec 28, 2020

@davisonja

…lash

Labels

alpha

included in alpha release