WebServer: use String when working with Basic authentication by mcspr · Pull Request #8548 · esp8266/Arduino (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation5 Commits4 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Avoid blowing up user code when $user:$password string is longer than
127 bytes. Use String to both manage the memory and handle concatenation.
Also clean-up historical quicks such as
if(StringObject)that is always true since we implemented SSOauthReq = "";/authReq = String();, which will happen anyway(String)...casts that happen anyway, implicitly
Avoid blowing up user code when $user:$password string is longer than
127 bytes. Use String to both manage the memory and handle concatenation.
Also clean-up historical quicks such as
authReq = "";/authReq = String();, which will happen anyway(String)...casts that happen anyway, implicitly
that may beclosed by this pull request
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull request
Avoid blowing up user code when $user:$password string is longer than
127 bytes. Use String to both manage the memory and handle concatenation.
Also clean-up historical quicks such as
if(StringObject)that is always true since we implemented SSOauthReq = "";/authReq = String();, which will happen anyway(String)...casts that happen anyway, implicitly (and which is also not a 'cast' btw, we do init it)
2 participants
