Fix DHCP server pbuf handling and allow to change netif address by mcspr · Pull Request #8602 · esp8266/Arduino (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation0 Commits5 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
See #8582 (comment)
Fix sending NACK (fix pointer to pointer), use helper function to fill pbuf with data pointer
This properly handles the case when pbuf->len is less than struct size
We must use SDK functions, so static IP could be set through wifi_set_ip_info
As noticed in esp8266#8582 (comment)
Can't really use server.begin() and server.end() directly, only
default static IP is applied to the interface since DHCP server is
deemed 'running' (see wifi_softap_dhcps_status() return value)
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull request
- Fix sending NACK, use helper function to fill pbuf
As noticed in esp8266#8582 (comment)
Plus, handle the case when pbuf->len is less than struct size
- Make sure to call SDK functions to start and stop DHCP server
As noticed in esp8266#8582 (comment)
Can't really use server.begin() and server.end() directly, only
default static IP is applied to the interface since DHCP server is
deemed 'running' (see wifi_softap_dhcps_status() return value)
- s
Co-authored-by: david gauchard gauchard@laas.fr
2 participants
