fix(zigbee): Increase timeout, commision again on failure + setScanDuration by P-R-O-C-H-Y · Pull Request #10651 · espressif/arduino-esp32 (original) (raw)

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

P-R-O-C-H-Y

@P-R-O-C-H-Y

me-no-dev

lucasssvaz

@P-R-O-C-H-Y

SuGlider

@pre-commit-ci-lite

Jason2866 added a commit to tasmota/arduino-esp32 that referenced this pull request

Nov 27, 2024

Co-authored-by: Rodrigo Garcia rodrigo.garcia@espressif.com Co-authored-by: Jan Procházka 90197375+P-R-O-C-H-Y@users.noreply.github.com

Jason2866 added a commit to tasmota/arduino-esp32 that referenced this pull request

Dec 6, 2024

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

Co-authored-by: Rodrigo Garcia rodrigo.garcia@espressif.com Co-authored-by: Jan Procházka 90197375+P-R-O-C-H-Y@users.noreply.github.com Co-authored-by: Me No Dev me-no-dev@users.noreply.github.com Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

Jason2866 added a commit to tasmota/arduino-esp32 that referenced this pull request

Dec 11, 2024

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

GeneralUtils::hexDump() doesn't output anything if the log level is not "VERBOSE". Additionally, it is very CPU intensive, even when it doesn't output anything. So it is much better to not call it at all if not needed.

In a simple program which calls BLECharacteristic::notify() every 50 ms, the performance gain of this little optimization is 37% in release mode (-O3) and 57% in debug mode.

Of course, the "#if ARDUHAL_LOG_LEVEL >= ARDUHAL_LOG_LEVEL_VERBOSE" guard could also be put inside the GeneralUtils::hexDump() function itself. But it's better to put it here also, as it is clearer (indicating a verbose log thing) and it allows to remove the "m_value.getValue().c_str()" call, which is in itself quite CPU intensive.

Calls to BLEUtils::buildHexData() don't output anything when the log level is not "VERBOSE" or "DEBUG". As this function is quite CPU intensive, it is better to not call it when not needed.

Co-authored-by: Lucas Saavedra Vaz 32426024+lucasssvaz@users.noreply.github.com

Co-authored-by: Rodrigo Garcia rodrigo.garcia@espressif.com

Co-authored-by: Rodrigo Garcia rodrigo.garcia@espressif.com Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

Added custom boards variants from PCBCUPID - GLYPH C3, GLYPHC6 & GLYPHH2 based on ESP32C3, ESP32C6 & ESP32H2

Co-authored-by: srini srinivasanm329@gmail.com Co-authored-by: Jan Procházka 90197375+P-R-O-C-H-Y@users.noreply.github.com Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

For use in sketches as default button

Co-authored-by: Rodrigo Garcia rodrigo.garcia@espressif.com Co-authored-by: Jan Procházka 90197375+P-R-O-C-H-Y@users.noreply.github.com Co-authored-by: Me No Dev me-no-dev@users.noreply.github.com Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: Sylvain Quendez sylvain.quendez@gmail.com Co-authored-by: Lucas Saavedra Vaz 32426024+lucasssvaz@users.noreply.github.com Co-authored-by: PCB CUPID 123002577+pcbcupid@users.noreply.github.com Co-authored-by: srini srinivasanm329@gmail.com Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Michael Stegen mstegen@users.noreply.github.com