test(wokwi): Add I2C Master test and enable GPIO and PSRAM tests by lucasssvaz · Pull Request #10848 · espressif/arduino-esp32 (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation8 Commits7 Checks28 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Description of Change

Added new I2C master test.
Enabled already existing PSRAM and GPIO tests.

Tests scenarios

Locally

👋 Hello lucasssvaz, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 188e1e7

Test Results

62 files 62 suites 6m 38s ⏱️
21 tests 21 ✅ 0 💤 0 ❌
153 runs 153 ✅ 0 💤 0 ❌

Results for commit 188e1e7.

♻️ This comment has been updated with latest results.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucasssvaz any chance this i2c test suite can be extended to also perform an i2c scan before initialising the i2c component, as we are seeing ESP_ERR_TIMEOUT: I2C Bus Busy returned from a scan (worked @ 3.0.7, broken in 3.1.1, unchanged code).

@lucasssvaz any chance this i2c test suite can be extended to also perform an i2c scan before initialising the i2c component, as we are seeing ESP_ERR_TIMEOUT: I2C Bus Busy returned from a scan (worked @ 3.0.7, broken in 3.1.1, unchanged code).

Sure, I will take a look. Is there anything specific you think would be nice to have in the test ?

Not really, although it now turns out that we see a normal successful scan with the plain Wire Scan example, but when using the same code in our WipperSnapper firmware (with wifi active) we are seeing the ESP_ERR_TIMEOUT: I2C Bus Busy messages at random addresses when scanning. Maybe doing the scan with other peripherals / tasks active would be a good thing to test? We are only experiencing this on the ESP32-S2 based boards in BSP 3.1.x for whatever that is worth.

…

On Fri, 28 Feb 2025 at 03:19, Lucas Saavedra Vaz ***@***.***> wrote:@lucasssvaz <https://github.com/lucasssvaz> any chance this i2c test suite can be extended to also perform an i2c scan before initialising the i2c component, as we are seeing ESP_ERR_TIMEOUT: I2C Bus Busy returned from a scan (worked @ 3.0.7, broken in 3.1.1, unchanged code). Sure, I will take a look. Is there anything specific you think would be nice to have in the test ? — Reply to this email directly, view it on GitHub <#10848 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABTBZ47BULM32SAJ6SFSURL2R7IUDAVCNFSM6AAAAABVBVM2FSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBZGYZDGNRYGM> . You are receiving this because you commented.Message ID: ***@***.***> [image: lucasssvaz]*lucasssvaz* left a comment (espressif/arduino-esp32#10848) <#10848 (comment)>@lucasssvaz <https://github.com/lucasssvaz> any chance this i2c test suite can be extended to also perform an i2c scan before initialising the i2c component, as we are seeing ESP_ERR_TIMEOUT: I2C Bus Busy returned from a scan (worked @ 3.0.7, broken in 3.1.1, unchanged code). Sure, I will take a look. Is there anything specific you think would be nice to have in the test ? — Reply to this email directly, view it on GitHub <#10848 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABTBZ47BULM32SAJ6SFSURL2R7IUDAVCNFSM6AAAAABVBVM2FSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBZGYZDGNRYGM> . You are receiving this because you commented.Message ID: ***@***.***>

@tyeth PTAL at #11022. Added a test to scan the bus while the Wi-Fi is running.

Looks great! Thanks for going the extra mile 🙏