lib: use req.socket over deprecated req.connection by bjohansebas · Pull Request #6705 · expressjs/express (original) (raw)
Navigation Menu
Appearance settings
- AI CODE CREATION
* GitHub CopilotWrite better code with AI
* GitHub Copilot appDirect agents from issue to merge
* MCP RegistryNewIntegrate external tools - DEVELOPER WORKFLOWS
* ActionsAutomate any workflow
* CodespacesInstant dev environments
* IssuesPlan and track work
* Code ReviewManage code changes - APPLICATION SECURITY
* GitHub Advanced SecurityFind and fix vulnerabilities
* Code securitySecure your code as you build
* Secret protectionStop leaks before they start - EXPLORE
* Why GitHub
* Documentation
* Blog
* Changelog
* Marketplace
- AI CODE CREATION
- BY COMPANY SIZE
* Enterprises
* Small and medium teams
* Startups
* Nonprofits - BY USE CASE
* App Modernization
* DevSecOps
* DevOps
* CI/CD
* View all use cases - BY INDUSTRY
* Healthcare
* Financial services
* Manufacturing
* Government
* View all industries
- BY COMPANY SIZE
- EXPLORE BY TOPIC
* AI
* Software Development
* DevOps
* Security
* View all topics - EXPLORE BY TYPE
* Customer stories
* Events & webinars
* Ebooks & reports
* Business insights
* GitHub Skills - SUPPORT & SERVICES
* Documentation
* Customer support
* Community forum
* Trust center
* Partners
- EXPLORE BY TOPIC
- COMMUNITY
* GitHub SponsorsFund open source developers - PROGRAMS
* Security Lab
* Maintainer Community
* Accelerator
* GitHub Stars
* Archive Program - REPOSITORIES
* Topics
* Trending
* Collections
- COMMUNITY
- Pricing
Provide feedback
We read every piece of feedback, and take your input very seriously.
Include my email address so I can be contacted
Saved searches
Use saved searches to filter your results more quickly
Appearance settings
Notifications You must be signed in to change notification settings
Additional navigation options
Merged
merged 1 commit into
masterfrom
Aug 21, 2025
ConversationCommits (1)ChecksFiles changed
Merged
lib: use req.socket over deprecated req.connection#6705
merged 1 commit into
masterfrom
Conversation
bjohansebas commented
Copy link Copy Markdown
Member
req.connection was only deprecated in the documentation, but it’s possible that a runtime deprecation will be added since internally it calls socket, so it’s better to start migrating.
https://nodejs.org/dist/latest/docs/api/deprecations.html#DEP0133
`[lib: use req.socket over deprecated req.connection](/expressjs/express/pull/6705/commits/0c6bcf31484bad99d24d2022802804e056108ff0 "lib: use req.socket over deprecated req.connection
Signed-off-by: Sebastian Beltran bjohansebas@gmail.com") `
[0c6bcf3](/expressjs/express/pull/6705/commits/0c6bcf31484bad99d24d2022802804e056108ff0)
Signed-off-by: Sebastian Beltran bjohansebas@gmail.com
bjohansebas requested a review from a team
Phillip9587 approved these changes Aug 13, 2025
UlisesGascon approved these changes Aug 13, 2025
bjohansebas merged commit 89f198c into master
26 checks passed
bjohansebas deleted the connection branch
UlisesGascon mentioned this pull request
Merged
davidshen84 mentioned this pull request
build(deps): bump express from 5.1.0 to 5.2.1davidshen84/davidshen84.github.io#124
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
UlisesGascon UlisesGascon approved these changes
Phillip9587 Phillip9587 approved these changes
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.