Ignore kBottommostFiles compaction logic when allow_ingest_behind by cbi42 · Pull Request #10767 · facebook/rocksdb (original) (raw)

cbi42 marked this pull request as draft

October 3, 2022 21:53

cbi42 marked this pull request as ready for review

October 3, 2022 23:27

ajkr approved these changes Oct 4, 2022

cbi42 mentioned this pull request

Oct 5, 2022

riversand963 pushed a commit to riversand963/rocksdb that referenced this pull request

Oct 5, 2022

…cebook#10767)

Summary: fix for facebook#10752 where RocksDB could be in an infinite compaction loop (with compaction reason kBottommostFiles) if allow_ingest_behind is enabled and the bottommost level is unfilled.

Pull Request resolved: facebook#10767

Test Plan: Added a unit test to reproduce the compaction loop.

Reviewed By: ajkr

Differential Revision: D40031861

Pulled By: ajkr

fbshipit-source-id: 71c4b02931fbe507a847632905404c9b8fa8c96b

riversand963 pushed a commit that referenced this pull request

Oct 5, 2022

…0767)

Summary: fix for #10752 where RocksDB could be in an infinite compaction loop (with compaction reason kBottommostFiles) if allow_ingest_behind is enabled and the bottommost level is unfilled.

Pull Request resolved: #10767

Test Plan: Added a unit test to reproduce the compaction loop.

Reviewed By: ajkr

Differential Revision: D40031861

Pulled By: ajkr

fbshipit-source-id: 71c4b02931fbe507a847632905404c9b8fa8c96b

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})