fix(fmt): 'layout' is not a keyword by DaniPopes · Pull Request #10656 · foundry-rs/foundry (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

DaniPopes

Same as #10556, but still doesn't allow layout everywhere due to limitations described in previous PRs (only layout = x; is not allowed, but uint layout = x; and everywhere else is).
With this PR, this is the most we can allow of the new not-actually-keyword keywords.

Fixes #10654.

@DaniPopes

@grandizzy

awesome 🙏 , could release a 1.2.2 with fix

grandizzy

grandizzy pushed a commit to grandizzy/foundry that referenced this pull request

May 30, 2025

@DaniPopes @grandizzy

grandizzy added a commit that referenced this pull request

May 30, 2025

use Optimism mainnet instead of DRPC due to limits


Co-authored-by: DaniPopes 57450786+DaniPopes@users.noreply.github.com Co-authored-by: zerosnacks 95942363+zerosnacks@users.noreply.github.com

Reviewers

@grandizzy grandizzy grandizzy approved these changes

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

2 participants

@DaniPopes @grandizzy