diagnose: avoid polluting stderr stream in Git diagnostic by mjcheetham · Pull Request #1590 · git-ecosystem/git-credential-manager (original) (raw)

@mjcheetham

Avoid poluting the standard error stream with a 'fatal' Git error message during the Git diagnostic run as part of the diagnose command.

When checking if we are inside of a Git repo we should be using an explicit check for IGit::IsInsideRepository rather than trying to get the current repo path and checking for null.

vdye

vdye approved these changes Apr 17, 2024

mjcheetham added a commit that referenced this pull request

Apr 18, 2024

@mjcheetham

Changes:

@dscho dscho changed the titlediagnose: avoid poluting stderr stream in Git diagnostic diagnose: avoid polluting stderr stream in Git diagnostic

Jun 11, 2024

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})