http2: don't log expected errors from writing invalid trailers · golang/net@b73e574 (original) (raw)

Skip to content

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Commit b73e574

neildgopherbot

authored and

committed

http2: don't log expected errors from writing invalid trailers

Change-Id: I1c8af5a1f7539a25d5602a7bc8e15756d3cafa56 Reviewed-on: https://go-review.googlesource.com/c/net/+/653695LUCI-TryBot-Result: Go LUCI golang-scoped@luci-project-accounts.iam.gserviceaccount.com Auto-Submit: Damien Neil dneil@google.com Reviewed-by: Jonathan Amsterdam jba@google.com

File tree

1 file changed

lines changed

1 file changed

lines changed

Original file line number Diff line number Diff line change
@@ -2814,6 +2814,8 @@ func testServerWritesTrailers(t *testing.T, withFlush bool) {
2814 2814 w.Header().Set("Trailer", "should not be included; Forbidden by RFC 7230 4.1.2")
2815 2815 return nil
2816 2816 }, func(st *serverTester) {
2817 +// Ignore errors from writing invalid trailers.
2818 +st.h1server.ErrorLog = log.New(io.Discard, "", 0)
2817 2819 getSlash(st)
2818 2820 st.wantHeaders(wantHeader{
2819 2821 streamID: 1,