make getCameraTarget consistent with getCameraOrbit by elalish · Pull Request #4895 · google/model-viewer (original) (raw)

Skip to content

Navigation Menu

Sign in

Appearance settings

• • AI CODE CREATION
    * GitHub CopilotWrite better code with AI
    * GitHub SparkBuild and deploy intelligent apps
    * GitHub ModelsManage and compare prompts
    * MCP RegistryNewIntegrate external tools
  • DEVELOPER WORKFLOWS
    * ActionsAutomate any workflow
    * CodespacesInstant dev environments
    * IssuesPlan and track work
    * Code ReviewManage code changes
  • APPLICATION SECURITY
    * GitHub Advanced SecurityFind and fix vulnerabilities
    * Code securitySecure your code as you build
    * Secret protectionStop leaks before they start
  • EXPLORE
    * Why GitHub
    * Documentation
    * Blog
    * Changelog
    * Marketplace

View all features

• • BY COMPANY SIZE
    * Enterprises
    * Small and medium teams
    * Startups
    * Nonprofits
  • BY USE CASE
    * App Modernization
    * DevSecOps
    * DevOps
    * CI/CD
    * View all use cases
  • BY INDUSTRY
    * Healthcare
    * Financial services
    * Manufacturing
    * Government
    * View all industries

View all solutions

• • EXPLORE BY TOPIC
    * AI
    * Software Development
    * DevOps
    * Security
    * View all topics
  • EXPLORE BY TYPE
    * Customer stories
    * Events & webinars
    * Ebooks & reports
    * Business insights
    * GitHub Skills
  • SUPPORT & SERVICES
    * Documentation
    * Customer support
    * Community forum
    * Trust center
    * Partners

View all resources

• • COMMUNITY
    * GitHub SponsorsFund open source developers
  • PROGRAMS
    * Security Lab
    * Maintainer Community
    * Accelerator
    * GitHub Stars
    * Archive Program
  • REPOSITORIES
    * Topics
    * Trending
    * Collections
• • ENTERPRISE SOLUTIONS
    * Enterprise platformAI-powered developer platform
  • AVAILABLE ADD-ONS
    * GitHub Advanced SecurityEnterprise-grade security features
    * Copilot for BusinessEnterprise-grade AI features
    * Premium SupportEnterprise-grade 24/7 support
• Pricing

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

google / model-viewer Public

• Notifications You must be signed in to change notification settings

• Fork926

• Star 8.1k

• Code

• Issues 103

• Pull requests 9

• Discussions

• Actions

• Projects

• Wiki

• Security and quality

• Insights

Additional navigation options

Merged

elalish

merged 10 commits into

masterfrom

fixGetTarget

Sep 25, 2024

ConversationCommits (10)ChecksFiles changed

Merged

make getCameraTarget consistent with getCameraOrbit#4895

elalish

merged 10 commits into

masterfrom

fixGetTarget

Conversation

Copy link Copy Markdown

Contributor

elalish commented

Sep 23, 2024

getCameraOrbit returns the instantaneous camera position, not the goal position, but getCameraTarget was returning the target goal, which made camera syncing difficult between several model-viewer elements. Now fixed.

[make getCameraTarget consistent with getCameraOrbit](/google/model-viewer/pull/4895/commits/f28044192db88147bdfaacfa7070f58e38317956 "make getCameraTarget consistent with getCameraOrbit")

[f280441](/google/model-viewer/pull/4895/commits/f28044192db88147bdfaacfa7070f58e38317956)

elalish self-assigned this

Sep 23, 2024

elalish added 9 commits

September 23, 2024 13:58

[reenable tests](/google/model-viewer/pull/4895/commits/5188de8b083a9c7b8aa47b3dec1826a8a533a1df "reenable tests")

[5188de8](/google/model-viewer/pull/4895/commits/5188de8b083a9c7b8aa47b3dec1826a8a533a1df)

[fix tests?](/google/model-viewer/pull/4895/commits/d2fa5e47df9ddb44202b52fdfac4bbe51f3fecb4 "fix tests?")

[d2fa5e4](/google/model-viewer/pull/4895/commits/d2fa5e47df9ddb44202b52fdfac4bbe51f3fecb4)

[fix more tests](/google/model-viewer/pull/4895/commits/50f08e3e9d73f3eb86dc3e364eb61274b77c47de "fix more tests")

[50f08e3](/google/model-viewer/pull/4895/commits/50f08e3e9d73f3eb86dc3e364eb61274b77c47de)

[fix more tests](/google/model-viewer/pull/4895/commits/d96360f3f1565ba3cb2838082b072011def351fd "fix more tests")

[d96360f](/google/model-viewer/pull/4895/commits/d96360f3f1565ba3cb2838082b072011def351fd)

[fix more flaky tests](/google/model-viewer/pull/4895/commits/0fcc33cd19cb3898c127df644dee30a7102c7f20 "fix more flaky tests")

[0fcc33c](/google/model-viewer/pull/4895/commits/0fcc33cd19cb3898c127df644dee30a7102c7f20)

[fix more flaky tests](/google/model-viewer/pull/4895/commits/b1a5100a6197b2dad09fbc8fca6a8bfd6cb09645 "fix more flaky tests")

[b1a5100](/google/model-viewer/pull/4895/commits/b1a5100a6197b2dad09fbc8fca6a8bfd6cb09645)

[Merge branch 'master' of github.com:google/model-viewer into fixGetTa…](/google/model-viewer/pull/4895/commits/b1fdf3a48d71fc9dc8d1cf8efefd1d26c3499484 "Merge branch 'master' of github.com:google/model-viewer into fixGetTarget")

[b1fdf3a](/google/model-viewer/pull/4895/commits/b1fdf3a48d71fc9dc8d1cf8efefd1d26c3499484)

…rget

[skip flaky tests](/google/model-viewer/pull/4895/commits/9cbe15bee3f8e0a73b0a01b21c1163262b5cf074 "skip flaky tests")

[9cbe15b](/google/model-viewer/pull/4895/commits/9cbe15bee3f8e0a73b0a01b21c1163262b5cf074)

[skip another flaky test](/google/model-viewer/pull/4895/commits/c8fa78a5990f5caaeaf990189604b876527d38b2 "skip another flaky test")

[c8fa78a](/google/model-viewer/pull/4895/commits/c8fa78a5990f5caaeaf990189604b876527d38b2)

elalish merged commit ce88f65 into master

Sep 25, 2024

elalish deleted the fixGetTarget branch

September 25, 2024 17:28

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

elalish

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant