Regenerate redis client by yoshi-automation 路 Pull Request #4644 路 googleapis/google-cloud-java (original) (raw)

@yoshi-automation

@googlebot googlebot added the cla: yes

This human has signed the Contributor License Agreement.

label

Mar 6, 2019

sduskis pushed a commit that referenced this pull request

Apr 15, 2019

@kimkyung-goog @sduskis

Make the SubscriberStubSettings refer to the user provided executor provider instead of a fixed instantiation of it. If the user provides an InstantiatingExecutorProvider instead of a FixedExecutorProvider, this will actually instantiate more than one as the user would expect. It will still only instantiate one for all connections to share, and will do so until the next PR which will make them have different stub instantiations.

Set the isDirectory flag appropriately when using the currentDirectory() option

Now that this uses a LinkedBlockingDeque for batches, this is no longer necessary.

Also regenerate the Compute client to match the newest version of gax.

SSLHandshakeExceptions are not retryable, as it is most probably an indication that the client does not accept the server certificate.

This increases throughput by reducing contention on the executor queue mutex and makes the Subscriber implementation more accurately reflect the users intent when an InstantiatingExecutorProvider is passed.

pendingWrites.add() was not guaranteed to be called before pendingWrites.remove()

Reduce contention on pendingWrites by using a ConcurrentHashMap instead.

This pull request updates the documentation and adds an example.

mvn com.coveo:fmt-maven-plugin:format

Fixing a copy&paste typo

@sduskis

(cherry picked from commit 8255a9b)

This change modifies the enhanced stub for the BigQuery storage client to pass through the user-specified header provider to the storage settings base class at creationt ime. This addresses an issue where user-specified headers were being ignored when creating a client object.

google-cloud-logging-logback: #3215 allow user to specify custom LoggingOptions

Transactions can always be aborted by Cloud Spanner, and all transaction code should therefore be surrounded by with abort safeguarding.

Refactor SpannerImpl: Move AbstractResultSet to separate file

Spanner: Refactor SpannerImpl - Move AbstractReadContext to separate file

refactor SpannerImpl: move InstanceAdminClient to separate file

Date parsing using a regular expression is slower than a specific implementation for the only format that is supported.

refactor SpannerImpl: move TransactionRunnerImpl to separate file

add support for newFileChannel(...)

This removes the failure mode described in #2452 that can occur when MaxOutstandingElementCount is low and there is more than one connection. In this case, it is possible for an individual MessageDispatcher to have no outstanding in-flight messages, but also be blocked by flow control with a whole new batch outstanding. In this case, it will never make progress on that batch since it will never receive another batch and the queue was made to not be shared in #4590, so the batch will never be pulled off by another MessageDispatcher.

By changing this to use a blocking flow controller, this will never happen, as each batch will synchronously wait until it is allowed by flow control before being processed.

kamalaboulhosn added a commit that referenced this pull request

Jul 9, 2019

@kamalaboulhosn

When the rpc timeout is zero, then it should be treated as disabled not actual 0

Ref: https://github.com/googleapis/gax-java/blob/master/gax/src/main/java/com/google/api/gax/batching/BatchingSettings.java

BREAKING CHANGE: The areTimestampsInSnapshotsEnabled() setting is now enabled by default so timestamp fields read from a DocumentSnapshot will be returned as Timestamp objects instead of Date. Any code expecting to receive a Date object must be updated.

This is required for v1 and accepted in v1beta1.

Port of googleapis/nodejs-firestore@52c7381

In Mockito 2, if a method expects a primitive type, but an any(.class) matcher is used in its place, it will throw an error. To prepare for this upcoming breakage, change all existing any(.class) matchers to use the correct any() matcher.

Ref: https://github.com/googleapis/google-cloud-java/blob/ed7bc857a05b34eed6be182d4798a62bf09cd394/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java#L497

This is needed for hbase adapter transition

Make the SubscriberStubSettings refer to the user provided executor provider instead of a fixed instantiation of it. If the user provides an InstantiatingExecutorProvider instead of a FixedExecutorProvider, this will actually instantiate more than one as the user would expect. It will still only instantiate one for all connections to share, and will do so until the next PR which will make them have different stub instantiations.

Set the isDirectory flag appropriately when using the currentDirectory() option

Now that this uses a LinkedBlockingDeque for batches, this is no longer necessary.

Also regenerate the Compute client to match the newest version of gax.

SSLHandshakeExceptions are not retryable, as it is most probably an indication that the client does not accept the server certificate.

This increases throughput by reducing contention on the executor queue mutex and makes the Subscriber implementation more accurately reflect the users intent when an InstantiatingExecutorProvider is passed.

pendingWrites.add() was not guaranteed to be called before pendingWrites.remove()

Reduce contention on pendingWrites by using a ConcurrentHashMap instead.

This pull request updates the documentation and adds an example.

mvn com.coveo:fmt-maven-plugin:format

Fixing a copy&paste typo

@sduskis

(cherry picked from commit 8255a9b)

This change modifies the enhanced stub for the BigQuery storage client to pass through the user-specified header provider to the storage settings base class at creationt ime. This addresses an issue where user-specified headers were being ignored when creating a client object.

google-cloud-logging-logback: #3215 allow user to specify custom LoggingOptions

Transactions can always be aborted by Cloud Spanner, and all transaction code should therefore be surrounded by with abort safeguarding.

Refactor SpannerImpl: Move AbstractResultSet to separate file

Spanner: Refactor SpannerImpl - Move AbstractReadContext to separate file

refactor SpannerImpl: move InstanceAdminClient to separate file

Date parsing using a regular expression is slower than a specific implementation for the only format that is supported.

refactor SpannerImpl: move TransactionRunnerImpl to separate file

add support for newFileChannel(...)

This removes the failure mode described in #2452 that can occur when MaxOutstandingElementCount is low and there is more than one connection. In this case, it is possible for an individual MessageDispatcher to have no outstanding in-flight messages, but also be blocked by flow control with a whole new batch outstanding. In this case, it will never make progress on that batch since it will never receive another batch and the queue was made to not be shared in #4590, so the batch will never be pulled off by another MessageDispatcher.

By changing this to use a blocking flow controller, this will never happen, as each batch will synchronously wait until it is allowed by flow control before being processed.

Step 1:

  1. Removing the Deque parameter from SequentialExecutorService.callNextTaskAsync() and looking it up the Deque in the method
  2. Simplify AutoExecutor and CallbackExecutor after the refactoring in 1).

meltsufin pushed a commit that referenced this pull request

Apr 29, 2026

@kamalaboulhosn

When the rpc timeout is zero, then it should be treated as disabled not actual 0

Ref: https://github.com/googleapis/gax-java/blob/master/gax/src/main/java/com/google/api/gax/batching/BatchingSettings.java

BREAKING CHANGE: The areTimestampsInSnapshotsEnabled() setting is now enabled by default so timestamp fields read from a DocumentSnapshot will be returned as Timestamp objects instead of Date. Any code expecting to receive a Date object must be updated.

This is required for v1 and accepted in v1beta1.

Port of googleapis/nodejs-firestore@52c7381

In Mockito 2, if a method expects a primitive type, but an any(.class) matcher is used in its place, it will throw an error. To prepare for this upcoming breakage, change all existing any(.class) matchers to use the correct any() matcher.

Ref: https://github.com/googleapis/google-cloud-java/blob/ed7bc857a05b34eed6be182d4798a62bf09cd394/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java#L497

This is needed for hbase adapter transition

Make the SubscriberStubSettings refer to the user provided executor provider instead of a fixed instantiation of it. If the user provides an InstantiatingExecutorProvider instead of a FixedExecutorProvider, this will actually instantiate more than one as the user would expect. It will still only instantiate one for all connections to share, and will do so until the next PR which will make them have different stub instantiations.

Set the isDirectory flag appropriately when using the currentDirectory() option

Now that this uses a LinkedBlockingDeque for batches, this is no longer necessary.

Also regenerate the Compute client to match the newest version of gax.

SSLHandshakeExceptions are not retryable, as it is most probably an indication that the client does not accept the server certificate.

This increases throughput by reducing contention on the executor queue mutex and makes the Subscriber implementation more accurately reflect the users intent when an InstantiatingExecutorProvider is passed.

pendingWrites.add() was not guaranteed to be called before pendingWrites.remove()

Reduce contention on pendingWrites by using a ConcurrentHashMap instead.

This pull request updates the documentation and adds an example.

mvn com.coveo:fmt-maven-plugin:format

Fixing a copy&paste typo

@sduskis

(cherry picked from commit 8255a9b)

This change modifies the enhanced stub for the BigQuery storage client to pass through the user-specified header provider to the storage settings base class at creationt ime. This addresses an issue where user-specified headers were being ignored when creating a client object.

google-cloud-logging-logback: #3215 allow user to specify custom LoggingOptions

Transactions can always be aborted by Cloud Spanner, and all transaction code should therefore be surrounded by with abort safeguarding.

Refactor SpannerImpl: Move AbstractResultSet to separate file

Spanner: Refactor SpannerImpl - Move AbstractReadContext to separate file

refactor SpannerImpl: move InstanceAdminClient to separate file

Date parsing using a regular expression is slower than a specific implementation for the only format that is supported.

refactor SpannerImpl: move TransactionRunnerImpl to separate file

add support for newFileChannel(...)

This removes the failure mode described in #2452 that can occur when MaxOutstandingElementCount is low and there is more than one connection. In this case, it is possible for an individual MessageDispatcher to have no outstanding in-flight messages, but also be blocked by flow control with a whole new batch outstanding. In this case, it will never make progress on that batch since it will never receive another batch and the queue was made to not be shared in #4590, so the batch will never be pulled off by another MessageDispatcher.

By changing this to use a blocking flow controller, this will never happen, as each batch will synchronously wait until it is allowed by flow control before being processed.

Step 1:

  1. Removing the Deque parameter from SequentialExecutorService.callNextTaskAsync() and looking it up the Deque in the method
  2. Simplify AutoExecutor and CallbackExecutor after the refactoring in 1).

meltsufin pushed a commit that referenced this pull request

May 1, 2026

@kamalaboulhosn

When the rpc timeout is zero, then it should be treated as disabled not actual 0

Ref: https://github.com/googleapis/gax-java/blob/master/gax/src/main/java/com/google/api/gax/batching/BatchingSettings.java

BREAKING CHANGE: The areTimestampsInSnapshotsEnabled() setting is now enabled by default so timestamp fields read from a DocumentSnapshot will be returned as Timestamp objects instead of Date. Any code expecting to receive a Date object must be updated.

This is required for v1 and accepted in v1beta1.

Port of googleapis/nodejs-firestore@52c7381

In Mockito 2, if a method expects a primitive type, but an any(.class) matcher is used in its place, it will throw an error. To prepare for this upcoming breakage, change all existing any(.class) matchers to use the correct any() matcher.

Ref: https://github.com/googleapis/google-cloud-java/blob/ed7bc857a05b34eed6be182d4798a62bf09cd394/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java#L497

This is needed for hbase adapter transition

Make the SubscriberStubSettings refer to the user provided executor provider instead of a fixed instantiation of it. If the user provides an InstantiatingExecutorProvider instead of a FixedExecutorProvider, this will actually instantiate more than one as the user would expect. It will still only instantiate one for all connections to share, and will do so until the next PR which will make them have different stub instantiations.

Set the isDirectory flag appropriately when using the currentDirectory() option

Now that this uses a LinkedBlockingDeque for batches, this is no longer necessary.

Also regenerate the Compute client to match the newest version of gax.

SSLHandshakeExceptions are not retryable, as it is most probably an indication that the client does not accept the server certificate.

This increases throughput by reducing contention on the executor queue mutex and makes the Subscriber implementation more accurately reflect the users intent when an InstantiatingExecutorProvider is passed.

pendingWrites.add() was not guaranteed to be called before pendingWrites.remove()

Reduce contention on pendingWrites by using a ConcurrentHashMap instead.

This pull request updates the documentation and adds an example.

mvn com.coveo:fmt-maven-plugin:format

Fixing a copy&paste typo

@sduskis

(cherry picked from commit 8255a9b)

This change modifies the enhanced stub for the BigQuery storage client to pass through the user-specified header provider to the storage settings base class at creationt ime. This addresses an issue where user-specified headers were being ignored when creating a client object.

google-cloud-logging-logback: #3215 allow user to specify custom LoggingOptions

Transactions can always be aborted by Cloud Spanner, and all transaction code should therefore be surrounded by with abort safeguarding.

Refactor SpannerImpl: Move AbstractResultSet to separate file

Spanner: Refactor SpannerImpl - Move AbstractReadContext to separate file

refactor SpannerImpl: move InstanceAdminClient to separate file

Date parsing using a regular expression is slower than a specific implementation for the only format that is supported.

refactor SpannerImpl: move TransactionRunnerImpl to separate file

add support for newFileChannel(...)

This removes the failure mode described in #2452 that can occur when MaxOutstandingElementCount is low and there is more than one connection. In this case, it is possible for an individual MessageDispatcher to have no outstanding in-flight messages, but also be blocked by flow control with a whole new batch outstanding. In this case, it will never make progress on that batch since it will never receive another batch and the queue was made to not be shared in #4590, so the batch will never be pulled off by another MessageDispatcher.

By changing this to use a blocking flow controller, this will never happen, as each batch will synchronously wait until it is allowed by flow control before being processed.

Step 1:

  1. Removing the Deque parameter from SequentialExecutorService.callNextTaskAsync() and looking it up the Deque in the method
  2. Simplify AutoExecutor and CallbackExecutor after the refactoring in 1).

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})