Adjust circuit-breaker for #1113 by lfoppiano · Pull Request #1125 · grobidOrg/grobid (original) (raw)
Navigation Menu
Appearance settings
- AI CODE CREATION
* GitHub CopilotWrite better code with AI
* GitHub SparkBuild and deploy intelligent apps
* GitHub ModelsManage and compare prompts
* MCP RegistryNewIntegrate external tools - DEVELOPER WORKFLOWS
* ActionsAutomate any workflow
* CodespacesInstant dev environments
* IssuesPlan and track work
* Code ReviewManage code changes - APPLICATION SECURITY
* GitHub Advanced SecurityFind and fix vulnerabilities
* Code securitySecure your code as you build
* Secret protectionStop leaks before they start - EXPLORE
* Why GitHub
* Documentation
* Blog
* Changelog
* Marketplace
- AI CODE CREATION
- BY COMPANY SIZE
* Enterprises
* Small and medium teams
* Startups
* Nonprofits - BY USE CASE
* App Modernization
* DevSecOps
* DevOps
* CI/CD
* View all use cases - BY INDUSTRY
* Healthcare
* Financial services
* Manufacturing
* Government
* View all industries
- BY COMPANY SIZE
- EXPLORE BY TOPIC
* AI
* Software Development
* DevOps
* Security
* View all topics - EXPLORE BY TYPE
* Customer stories
* Events & webinars
* Ebooks & reports
* Business insights
* GitHub Skills - SUPPORT & SERVICES
* Documentation
* Customer support
* Community forum
* Trust center
* Partners
- EXPLORE BY TOPIC
- COMMUNITY
* GitHub SponsorsFund open source developers - PROGRAMS
* Security Lab
* Maintainer Community
* Accelerator
* GitHub Stars
* Archive Program - REPOSITORIES
* Topics
* Trending
* Collections
- COMMUNITY
- Pricing
Provide feedback
We read every piece of feedback, and take your input very seriously.
Include my email address so I can be contacted
Saved searches
Use saved searches to filter your results more quickly
Appearance settings
Notifications You must be signed in to change notification settings
Additional navigation options
Merged
lfoppiano merged 1 commit intomasterfrom
bugfix/fix-links-beginning-sent
Jun 12, 2024
ConversationCommits (1)ChecksFiles changed
Merged
Adjust circuit-breaker for #1113#1125
lfoppiano merged 1 commit intomasterfrom
bugfix/fix-links-beginning-sent
Conversation
Copy link Copy Markdown
Member
•
edited
Loading
In the fix for #1113:
if the URL is at beginning of the sentence/paragraph, it's normal to have both pos and matchingPosition.start) == 0, which should not cause any trouble (the string before will be empty).
This PR updates the >= with >. 😅
[Adjust circuit-breaker that would miss to identify urls at the beginn…](/grobidOrg/grobid/pull/1125/commits/c5c924ec480a765967a5d489d86718b3441b4a39 "Adjust circuit-breaker that would miss to identify urls at the beginning of the sentence/paragraph")
[c5c924e](/grobidOrg/grobid/pull/1125/commits/c5c924ec480a765967a5d489d86718b3441b4a39)
…ing of the sentence/paragraph
Copy link Copy Markdown
coveralls commented
coverage: 40.787%. remained the same
when pulling c5c924e on bugfix/fix-links-beginning-sent
into 694f0ed on master.
Support for biblio-glutton 0.3#1086
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Development
Successfully merging this pull request may close these issues.
2 participants
