Sampling algorithm differ from paper. · Issue #5 · hojonathanho/diffusion (original) (raw)

Skip to content

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

@ariel415el

Description

@ariel415el

Hi,
I want to elaborate on #2:
The sampling algorithm in your paper is a bit different that what shown in the paper.

The paper suggests this sample step
Screenshot from 2021-05-20 12-36-24

while you do this:
Screenshot from 2021-05-20 12-55-28

The clipping is done here

x_recon = tf.clip_by_value(x_recon, -1., 1.)

Now I checked and indeed, without the clipping, the two equations are the same.
Can you give any interpretation or intuition for the clipping and why it is needed?
It seem to be crucial for training while not mentioned in the paper

Thanks