fix vae dtype when accelerate config using --mixed_precision="fp16" by xduzhangjiayu · Pull Request #9601 · huggingface/diffusers (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits2 Checks8 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

xduzhangjiayu

What does this PR do?

Issue #9560
Fix vae dtype when accelerate config using --mixed_precision="fp16".

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@sayakpaul

@xduzhangjiayu

sayakpaul

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just left a comment.

vae.to(accelerator.device, dtype=torch.float32)
vae.to(accelerator.device, dtype=weight_dtype)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be like:

if args.upcast_vae: vae.to(accelerator.device, dtype=torch.float32) else: vae.to(accelerator.device, dtype=weight_dtype)

With upcast_vae being added to the arguments?

@xduzhangjiayu

@xduzhangjiayu

Thanks for the comment, I have modified the code.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

sayakpaul

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

leisuzz pushed a commit to leisuzz/diffusers that referenced this pull request

Oct 11, 2024

@xduzhangjiayu

…uggingface#9601)

sayakpaul pushed a commit that referenced this pull request

Dec 23, 2024

@xduzhangjiayu @sayakpaul

…9601)