Fix message attribute access after replacing dict with dataclass by albertvillanova · Pull Request #1534 · huggingface/smolagents (original) (raw)

Skip to content

Sign in

Appearance settings

View all features

View all solutions

View all resources

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

huggingface / smolagents Public

Additional navigation options

Merged

albertvillanova merged 1 commit intohuggingface:mainfrom

albertvillanova:fix-1449-fu-1533

Jul 8, 2025

ConversationCommits (1)ChecksFiles changed

Merged

Fix message attribute access after replacing dict with dataclass#1534

albertvillanova merged 1 commit intohuggingface:mainfrom

albertvillanova:fix-1449-fu-1533

Conversation

@albertvillanova

Copy link Copy Markdown

Member

@albertvillanova albertvillanova commented

Jul 8, 2025

Fix message attribute access after replacing dict with dataclass.

Fix bug introduced after the replacement of Message (TypedDict) with ChatMessage (dataclass), done in:

Related to:

@albertvillanova

[Fix message attribute access after replacing dict with dataclass](/huggingface/smolagents/pull/1534/commits/e5a60b0e4bfb278978cce687634495682c9faa1a "Fix message attribute access after replacing dict with dataclass")

[e5a60b0](/huggingface/smolagents/pull/1534/commits/e5a60b0e4bfb278978cce687634495682c9faa1a)

aymeric-roucher

aymeric-roucher approved these changes Jul 8, 2025

View reviewed changes

Copy link Copy Markdown

Collaborator

@aymeric-roucher aymeric-roucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @albertvillanova !

albertvillanova reacted with thumbs up emoji

@albertvillanova albertvillanova merged commit 824ce4a into huggingface:main

Jul 8, 2025

3 checks passed

@albertvillanova albertvillanova deleted the fix-1449-fu-1533 branch

July 8, 2025 15:33

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@aymeric-roucher aymeric-roucher aymeric-roucher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@albertvillanova @aymeric-roucher