[New] support eslint 9 by G-Rath · Pull Request #2996 · import-js/eslint-plugin-import (original) (raw)

sparten11740 pushed a commit to ExodusForks/eslint-plugin-import that referenced this pull request

Discovered this issue in import-js#2996 (comment)

This change improves the logic for generating the cache key used for both the exportMap cache and resolver cache when using flat config. Prior to this change, the cache key was a combination of the parserPath, a hash of the parserOptions, a hash of the plugin settings, and the path of the file. When using flat config, parserPath isn't provided. So, there's the possibility of incorrect cache objects being used if someone ran with this plugin using different parsers within the same lint execution, if parserOptions and settings are the same. The equivalent cacheKey construction when using flat config is to use languageOptions as a component of the key, rather than parserPath and parserOptions. One caveat is that the parser property of languageOptions is an object that oftentimes has the same two functions (parse and parseForESLint). This won't be reliably distinct when using the base JSON.stringify function to detect changes. So, this implementation uses a replace function along with JSON.stringify to stringify function properties along with other property types.

To ensure that this will work properly with v9, I also tested this against import-js#2996 with v9 installed. Not only does it pass all tests in that branch, but it also removes the need to add this exception: import-js#2996 (comment)