Remove deprecated -logFile parameter by darxriggs · Pull Request #107 · jenkinsci/swarm-plugin (original) (raw)

Skip to content

Sign in

Appearance settings

View all features

View all solutions

View all resources

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

jenkinsci / swarm-plugin Public

Additional navigation options

Merged

basil

merged 1 commit into

jenkinsci:masterfrom

darxriggs:remove-logFile-parameter

Jun 2, 2019

ConversationCommits (1)ChecksFiles changed

Merged

Remove deprecated -logFile parameter#107

basil

merged 1 commit into

jenkinsci:masterfrom

darxriggs:remove-logFile-parameter

Conversation

@darxriggs

@darxriggs darxriggs commented

Jun 2, 2019

Copy link Copy Markdown

Contributor

It was anyway implemented in way that it could not be used anymore.

This should properly be mentioned in the changelog and removed from the available options on the plugin's documentation page https://wiki.jenkins.io/display/JENKINS/Swarm+Plugin.

@darxriggs

`[Remove deprecated -logFile parameter](/jenkinsci/swarm-plugin/pull/107/commits/d7e26405cc85b4550ff876ab825ae58b8705152d "Remove deprecated -logFile parameter

It was anyway implemented in way that it could not be used anymore.

This should properly be mentioned in the changelog and removed from the available options on the plugin's documentation page: https://wiki.jenkins.io/display/JENKINS/Swarm+Plugin") `

[d7e2640](/jenkinsci/swarm-plugin/pull/107/commits/d7e26405cc85b4550ff876ab825ae58b8705152d)

It was anyway implemented in way that it could not be used anymore.

This should properly be mentioned in the changelog and removed from the available options on the plugin's documentation page: https://wiki.jenkins.io/display/JENKINS/Swarm+Plugin

@basil

basil commented

Jun 2, 2019

Copy link Copy Markdown

Member

Thanks for the PR. I'll update the wiki page the next time I do a release.

@basil basil merged commit 84b64fb into jenkinsci:master

Jun 2, 2019

@darxriggs darxriggs deleted the remove-logFile-parameter branch

June 2, 2019 16:56

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@darxriggs @basil