[release-0.9] ⚠️ Client: Ensure no stale data remains in target object by k8s-ci-robot · Pull Request #1658 · kubernetes-sigs/controller-runtime (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This is an automated cherry-pick of #1640
/assign alvaroaleman
Fixes kubernetes-sigs#1639
The json deserializer of the stdlib and the one from Kube which aims to be compatible won't zero out all field types in the object it deserializes into, for example it lets slices be if the json does not contain that field. This means that if a non-empty variable is used for any api call with the client, the resulting content might be a mixture of previous content and what is on the server.
This PR adds a wrapper around the deserializer that will first zero the target object.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: k8s-ci-robot
To complete the pull request process, please assign droot after the PR has been reviewed.
You can assign the PR to them by writing /assign @droot in a comment when ready.
The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
This was just a test of the cherrypicker plugin, seems its working :)
Labels
Indicates the PR's author has signed the CNCF CLA.
Denotes a PR that changes 100-499 lines, ignoring generated files.