🐛 envtest: get gvk from hook struct instead of forcing set TypeMeta by sbueringer · Pull Request #1665 · kubernetes-sigs/controller-runtime (original) (raw)

timebertt added a commit to gardener/gardener that referenced this pull request

Oct 14, 2021

• Upgrade to k8s.io/*@v0.22.2 in go.mod

• [automated] make revendor

• [automated] make generate

• [automated] make revendor

github.com/go-openapi/spec seems to be orphaned after previous make generate

• Upgrade to c-r@v0.10.2 in go.mod

Also, upgrade setup-envtest (doesn't have a tagged release yet, so use release commit instead)

• [automated] make revendor

• Upgrade to controller-tools@v0.7.0 in go.mod

• [automated] make revendor

• Add missing WarningsOn{Create,Update} to rest strategies

• Replace dot imports for github.com/onsi/gomega/types

Fix linting errors: Assertion redeclared in this block (typecheck)

• Switch to typed values for WebhookInstallOptions.*Webhooks

ref kubernetes-sigs/controller-runtime#1626

• RequestCertificate now takes an optional requestedDuration

ref kubernetes/kubernetes#99494

• Switch to matchers.DeepEqual to test semantic equality

Maps (e.g. labels, selectors, resource requirements) might be sorted differently than expected. Hence, use semantic equality instead of strict equality, as this is what matters to us. Also, DeepEqual outputs yaml and adds a nice diff indicator instead of printing some large confusing go struct representation.

• Add new memorySwap field to expected kubelet config

ref kubernetes/kubernetes#102823

• Round condition.lastUpdateTime to seconds in test

There were several changes in the fake clients that might cause the failure to happen just now.

• Correct unit tests falsely succeeding

These tests were not preparing the test objects correctly: they only updated them in memory but not on the fake client. This wasn't caught until now because the fake client mimicked the real json decoder, which didn't unset fields not present on the server. Now that the fake client zeroes fields, the tests started failing (which is correct). So fix the tests.

ref kubernetes-sigs/controller-runtime#1651

• Remove workarounds for missing zeroing in json decoder

Now that the c-r client zeroes fields before decoding into the object, we can drop our workarounds for this, so basically drop kutil.CreateResetObjectFunc and its usages.

ref kubernetes-sigs/controller-runtime#1640

• Drop setting webhook gvk explicitly in envtest

webhookConfig.SetGroupVersionKind is not needed anymore with kubernetes-sigs/controller-runtime#1665

• Add some follow-up TODO comments

• [automated] make generate

but with go 1.16.9

• Address review comments