Fix lychee version check by mondeja · Pull Request #288 · lycheeverse/lychee-action (original) (raw)
Navigation Menu
Appearance settings
- AI CODE CREATION
* GitHub CopilotWrite better code with AI
* GitHub Copilot appDirect agents from issue to merge
* MCP RegistryNewIntegrate external tools - DEVELOPER WORKFLOWS
* ActionsAutomate any workflow
* CodespacesInstant dev environments
* IssuesPlan and track work
* Code ReviewManage code changes - APPLICATION SECURITY
* GitHub Advanced SecurityFind and fix vulnerabilities
* Code securitySecure your code as you build
* Secret protectionStop leaks before they start - EXPLORE
* Why GitHub
* Documentation
* Blog
* Changelog
* Marketplace
- AI CODE CREATION
- BY COMPANY SIZE
* Enterprises
* Small and medium teams
* Startups
* Nonprofits - BY USE CASE
* App Modernization
* DevSecOps
* DevOps
* CI/CD
* View all use cases - BY INDUSTRY
* Healthcare
* Financial services
* Manufacturing
* Government
* View all industries
- BY COMPANY SIZE
- EXPLORE BY TOPIC
* AI
* Software Development
* DevOps
* Security
* View all topics - EXPLORE BY TYPE
* Customer stories
* Events & webinars
* Ebooks & reports
* Business insights
* GitHub Skills - SUPPORT & SERVICES
* Documentation
* Customer support
* Community forum
* Trust center
* Partners
- EXPLORE BY TOPIC
- COMMUNITY
* GitHub SponsorsFund open source developers - PROGRAMS
* Security Lab
* Maintainer Community
* Accelerator
* GitHub Stars
* Archive Program - REPOSITORIES
* Topics
* Trending
* Collections
- COMMUNITY
- Pricing
Provide feedback
We read every piece of feedback, and take your input very seriously.
Include my email address so I can be contacted
Saved searches
Use saved searches to filter your results more quickly
Appearance settings
lycheeverse / lychee-action Public
Notifications You must be signed in to change notification settings
Additional navigation options
Merged
merged 1 commit into
mondeja:fix-lychee-version-check
May 8, 2025
ConversationCommits (1)ChecksFiles changed
Merged
merged 1 commit into
mondeja:fix-lychee-version-check
Conversation
mondeja commented
•
edited
Loading
Copy link Copy Markdown
Contributor
A change introduced in #279 triggers a weird error message. Check https://github.com/simple-icons/simple-icons/actions/runs/14554296040/job/40829177263#step:13:84
The problems are two as I can see:
lychee --version | head -n1 | cut -d" " -f4returns an empty string. It should be-f2as the output oflychee --versionislychee <version>- Semver comparisons are not possible using
-ltin Bash. That raises aninteger expression expected.
gecko655 reacted with thumbs up emoji
[Fix lychee version check](/lycheeverse/lychee-action/pull/288/commits/93bfa760ef1ef6e22a88ab929dc06d932910ed78 "Fix `lychee` version check")
[93bfa76](/lycheeverse/lychee-action/pull/288/commits/93bfa760ef1ef6e22a88ab929dc06d932910ed78)
mre commented
Copy link Copy Markdown
Member
Thanks for the fix @mondeja. ✌️
mre merged commit 82202e5 into lycheeverse:master
mondeja deleted the fix-lychee-version-check branch
mre mentioned this pull request
Warning in execution of action#290
Closed
MrG9090 approved these changes May 21, 2025
mre commented
Copy link Copy Markdown
Member
@MrG9090, approvals on pull requests, please. It creates noise in the form of GitHub notifications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
1 more reviewer
MrG9090 MrG9090 approved these changes
Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.