Added labels for make_addplot function (lines,bars,scatter). Missing …for _mscatter function. by ppseverin · Pull Request #277 · matplotlib/mplfinance (original) (raw)

@alexpvpmindustry Thanks for your interesting in, and expression of gratitude for, mplfinance. Much appreciated!

Here's the status: I am solidly involved in another project at this time, and in preparing for JupyterCon (hope to see you there) so I will be giving minimal attention to mplfinance at least until towards the end of May.

That said, if you read through the conversion above, you can see where I have made several suggestions regarding the code. I've also pointed out where I think we should be going with labels, annotations, and legends, specifically with regard to for which aspects of mplfinance these things should be supported. (until now, there appears to be no movement on my suggestions).

If you would like to contribute, along the lines of the discussion and requests above, then I will be happy to review any contributions. (Keep in mind that it has been a while since this PR was first entered, and the trunk may have since migrated somewhat; so a fresh clone may be in order). Alternatively you can wait for me to make these changes, in which case it will most likely be the middle of June or later before it will be done. As mentioned above, a core part of this particular enhancement is complete testing to ensure no existing functionality has been broken.