import: Use mattn/go-runewidth instead of zyedidia/go-runewidth by JoeKar · Pull Request #3601 · micro-editor/micro (original) (raw)

Skip to content

Navigation Menu

Sign in

Appearance settings

• • AI CODE CREATION
    * GitHub CopilotWrite better code with AI
    * GitHub SparkBuild and deploy intelligent apps
    * GitHub ModelsManage and compare prompts
    * MCP RegistryNewIntegrate external tools
  • DEVELOPER WORKFLOWS
    * ActionsAutomate any workflow
    * CodespacesInstant dev environments
    * IssuesPlan and track work
    * Code ReviewManage code changes
  • APPLICATION SECURITY
    * GitHub Advanced SecurityFind and fix vulnerabilities
    * Code securitySecure your code as you build
    * Secret protectionStop leaks before they start
  • EXPLORE
    * Why GitHub
    * Documentation
    * Blog
    * Changelog
    * Marketplace

View all features

• • BY COMPANY SIZE
    * Enterprises
    * Small and medium teams
    * Startups
    * Nonprofits
  • BY USE CASE
    * App Modernization
    * DevSecOps
    * DevOps
    * CI/CD
    * View all use cases
  • BY INDUSTRY
    * Healthcare
    * Financial services
    * Manufacturing
    * Government
    * View all industries

View all solutions

• • EXPLORE BY TOPIC
    * AI
    * Software Development
    * DevOps
    * Security
    * View all topics
  • EXPLORE BY TYPE
    * Customer stories
    * Events & webinars
    * Ebooks & reports
    * Business insights
    * GitHub Skills
  • SUPPORT & SERVICES
    * Documentation
    * Customer support
    * Community forum
    * Trust center
    * Partners

View all resources

• • COMMUNITY
    * GitHub SponsorsFund open source developers
  • PROGRAMS
    * Security Lab
    * Maintainer Community
    * Accelerator
    * GitHub Stars
    * Archive Program
  • REPOSITORIES
    * Topics
    * Trending
    * Collections
• • ENTERPRISE SOLUTIONS
    * Enterprise platformAI-powered developer platform
  • AVAILABLE ADD-ONS
    * GitHub Advanced SecurityEnterprise-grade security features
    * Copilot for BusinessEnterprise-grade AI features
    * Premium SupportEnterprise-grade 24/7 support
• Pricing

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

micro-editor / micro Public

• Notifications You must be signed in to change notification settings

• Fork1.3k

• Star 28.4k

• Code

• Issues 853

• Pull requests 148

• Discussions

• Actions

• Projects

• Wiki

• Security and quality

• Insights

Additional navigation options

Merged

JoeKar merged 2 commits intomicro-editor:masterfrom

JoeKar:import/go-runewidth

Jan 6, 2025

ConversationCommits (2)ChecksFiles changed

Merged

import: Use mattn/go-runewidth instead of zyedidia/go-runewidth#3601

JoeKar merged 2 commits intomicro-editor:masterfrom

JoeKar:import/go-runewidth

Conversation

Copy link Copy Markdown

Member

JoeKar commented

Jan 5, 2025

•

edited

Loading

The upstream version includes the changes added on top after the fork of zyedidia/go-runewidth.

#3601 (comment):

[...] both our downstream changes zyedidia/go-runewidth#1 and zyedidia/go-runewidth#2 were merged upstream in mattn/go-runewidth#44 and mattn/go-runewidth#47.

Fixes #3264

JoeKar added 2 commits

January 5, 2025 13:19

[import: Use mattn/go-runewidth instead of zyedidia/go-runewidth](/micro-editor/micro/pull/3601/commits/ab6e170ec9e674a789a5acbcc3d0d91f06f1191d "import: Use `mattn/go-runewidth` instead of `zyedidia/go-runewidth`")

[ab6e170](/micro-editor/micro/pull/3601/commits/ab6e170ec9e674a789a5acbcc3d0d91f06f1191d)

[import: Bump mattn/go-runewidth to v0.0.16](/micro-editor/micro/pull/3601/commits/d9956bde38291d6ab292eddb25e200539f34518c "import: Bump `mattn/go-runewidth` to `v0.0.16`")

[d9956bd](/micro-editor/micro/pull/3601/commits/d9956bde38291d6ab292eddb25e200539f34518c)

Andriamanitra approved these changes Jan 5, 2025

View reviewed changes

Copy link Copy Markdown

Contributor

Andriamanitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also fixes #3264 as the upstream version now includes Unicode 15 support

JoeKar reacted with thumbs up emoji

Copy link Copy Markdown

Collaborator

dmaluka commented

Jan 5, 2025

It would be worth mentioning in the PR description that both our downstream changes zyedidia/go-runewidth#1 and zyedidia/go-runewidth#2 were merged upstream in mattn/go-runewidth#44 and mattn/go-runewidth#47.

JoeKar reacted with thumbs up emoji

dmaluka approved these changes Jan 5, 2025

View reviewed changes

JoeKar merged commit c77ed02 into micro-editor:master

Jan 6, 2025

JoeKar deleted the import/go-runewidth branch

January 6, 2025 06:07

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

dmaluka dmaluka approved these changes

+1 more reviewer

Andriamanitra Andriamanitra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New emojis (2021 Unicode 14.0+) cause rendering issues

3 participants