Add MongoCommandStartedEventTags for Mongodb metrics by sshplendid · Pull Request #3069 · micrometer-metrics/micrometer (original) (raw)

Skip to content

Sign in

Appearance settings

View all features

View all solutions

View all resources

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

micrometer-metrics / micrometer Public

Additional navigation options

Merged

shakuzen

merged 1 commit into

micrometer-metrics:mainfrom

sshplendid:feature/support-database-tag-in-mongodb

Mar 22, 2022

ConversationCommits (1)ChecksFiles changed

Merged

Add MongoCommandStartedEventTags for Mongodb metrics#3069

shakuzen

merged 1 commit into

micrometer-metrics:mainfrom

sshplendid:feature/support-database-tag-in-mongodb

Conversation

@sshplendid

@sshplendid sshplendid commented

Mar 11, 2022

Copy link Copy Markdown

Contributor

Support database tag at MongoCommandEvent
This resolves #2932

`[Add MongoCommandStartedEventTags for Mongodb metrics](/micrometer-metrics/micrometer/pull/3069/commits/4c83d2a40ee682601d29e2030fc4ac32206863cd "Add MongoCommandStartedEventTags for Mongodb metrics

Support database tag at MongoCommandEvent This resolves #2932") `

[4c83d2a](/micrometer-metrics/micrometer/pull/3069/commits/4c83d2a40ee682601d29e2030fc4ac32206863cd)

Support database tag at MongoCommandEvent This resolves micrometer-metrics#2932

@shakuzen shakuzen closed this

Mar 22, 2022

@shakuzen shakuzen reopened this

Mar 22, 2022

@shakuzen shakuzen added module: micrometer-binders enhancement

A general enhancement

labels

Mar 22, 2022

@shakuzen shakuzen added this to the 2.0.0-M4 milestone

Mar 22, 2022

shakuzen

shakuzen approved these changes Mar 22, 2022

View reviewed changes

@shakuzen shakuzen left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you.

@shakuzen shakuzen merged commit 8d9db81 into micrometer-metrics:main

Mar 22, 2022

@izeye izeye mentioned this pull request

Mar 19, 2024

Add database tag to DefaultMongoCommandTagsProvider #4298

Merged

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@shakuzen shakuzen shakuzen approved these changes

Assignees

No one assigned

Labels

enhancement

A general enhancement

module: micrometer-binders

Projects

None yet

Milestone

1.10.0-M1

Development

Successfully merging this pull request may close these issues.

Support "database" tag in "mongodb.driver.commands" metric

2 participants

@sshplendid @shakuzen