Begin removing EDG workaround from ranges::to tests by CaseyCarter · Pull Request #4944 · microsoft/STL (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits1 Checks39 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
VSO-2208356 has been fixed internally. Disable the workaround internally, and mark the workaround for cleanup when VS 17.12p3 releases.
This mirrors MSVC-PR-577053.
VSO-2208356 has been fixed internally. Disable the workaround internally, and mark the workaround for cleanup when VS 17.12p3 releases.
This mirrors MSVC-PR-577053.
Adjust workaround for EDG bug Port MSVC-PR-577053
Port MSVC-PR-577053 Begin removing EDG workaround from ranges::to tests
Citing the MSVC-PR being mirrored in the PR description is great (yay autolink references), but it makes for an exceptionally opaque PR title / commit subject. When scanning history, it's much more useful to have brief descriptions of what changed. I've changed the title and added a bit more clarity than before (mentioning that this affects ranges::to tests).
(Yes I am a very picky kitty 🐈)
CaseyCarter added a commit to CaseyCarter/STL that referenced this pull request
Let's make these more consistent with the messages for find_package(Python) and the assembler. If nothing else, showing the path to the found clang-format may help folks who are finding the wrong version.
Remove extraneous element_type from ContiguousIterator
And while we're here, use value_type and difference_type where appropriate so we can easily see which int is which.
Remove unused include from P2163R3_invoke_r
This test doesn't need is_permissive.hpp after microsoft#4914.
Simplify construct_at constraint
Investigate a couple of libc++ failures
Add some missing #endif comments
These were incorrectly removed by microsoft#4944.
CaseyCarter added a commit to CaseyCarter/STL that referenced this pull request
- Pretty clang-format find/version check messages
Let's make these more consistent with the messages for
find_package(Python)and the assembler. If nothing else, showing the path to the found clang-format may help folks who are finding the wrong version. - Remove extraneous
element_typefromContiguousIteratorAnd while we're here, usevalue_typeanddifference_typewhere appropriate so we can easily see whichintis which. - Remove unused include from
P2163R3_invoke_rThis test doesn't needis_permissive.hppafter microsoft#4914. - Simplify
construct_atconstraint - Investigate a couple of libc++ failures
- Add some missing
#endifcomments These were incorrectly removed by microsoft#4944.
CaseyCarter added a commit to CaseyCarter/STL that referenced this pull request
- Pretty clang-format find/version check messages: Let's make these more consistent with the messages for
find_package(Python)and the assembler. Showing the path may help folks with problems. - Remove extraneous
element_typefromContiguousIterator: While we're here, let's usevalue_typeanddifference_typewhere appropriate so we can see whichintis which. - Remove unused include from
P2163R3_invoke_r: This test doesn't needis_permissive.hppafter microsoft#4914. - Simplify
construct_atconstraint - Investigate a couple of libc++ failures
- Add some missing
#endifcomments: These were incorrectly removed by microsoft#4944.
CaseyCarter added a commit to CaseyCarter/STL that referenced this pull request
CaseyCarter added a commit to CaseyCarter/STL that referenced this pull request
Labels
Related to test code
2 participants
