chore: CA1816 Call GC.SuppressFinalize correctly by JamieMagee · Pull Request #375 · microsoft/sbom-tool (original) (raw)
Navigation Menu
Appearance settings
- AI CODE CREATION
* GitHub CopilotWrite better code with AI
* GitHub Copilot appDirect agents from issue to merge
* MCP RegistryNewIntegrate external tools - DEVELOPER WORKFLOWS
* ActionsAutomate any workflow
* CodespacesInstant dev environments
* IssuesPlan and track work
* Code ReviewManage code changes - APPLICATION SECURITY
* GitHub Advanced SecurityFind and fix vulnerabilities
* Code securitySecure your code as you build
* Secret protectionStop leaks before they start - EXPLORE
* Why GitHub
* Documentation
* Blog
* Changelog
* Marketplace
- AI CODE CREATION
- BY COMPANY SIZE
* Enterprises
* Small and medium teams
* Startups
* Nonprofits - BY USE CASE
* App Modernization
* DevSecOps
* DevOps
* CI/CD
* View all use cases - BY INDUSTRY
* Healthcare
* Financial services
* Manufacturing
* Government
* View all industries
- BY COMPANY SIZE
- EXPLORE BY TOPIC
* AI
* Software Development
* DevOps
* Security
* View all topics - EXPLORE BY TYPE
* Customer stories
* Events & webinars
* Ebooks & reports
* Business insights
* GitHub Skills - SUPPORT & SERVICES
* Documentation
* Customer support
* Community forum
* Trust center
* Partners
- EXPLORE BY TOPIC
- COMMUNITY
* GitHub SponsorsFund open source developers - PROGRAMS
* Security Lab
* Maintainer Community
* Accelerator
* GitHub Stars
* Archive Program - REPOSITORIES
* Topics
* Trending
* Collections
- COMMUNITY
- Pricing
Provide feedback
We read every piece of feedback, and take your input very seriously.
Include my email address so I can be contacted
Saved searches
Use saved searches to filter your results more quickly
Appearance settings
Notifications You must be signed in to change notification settings
Additional navigation options
Merged
merged 1 commit into
mainfrom
Sep 21, 2023
ConversationCommits (1)ChecksFiles changed
Merged
chore: CA1816 Call GC.SuppressFinalize correctly#375
merged 1 commit into
mainfrom
Conversation
Copy link Copy Markdown
Member
CA1816: Call GC.SuppressFinalize correctly
Related to #340
GC.SuppressFinalize is required if a class can be inherited from. Adding sealed makes this impossible.
Open
codecov-commenter commented
•
edited
Loading
Copy link Copy Markdown
Codecov Report
Merging #375 (c5ddfa8) into main (32a90da) will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## main #375 +/- ##
Coverage 68.95% 68.95%
Files 241 241
Lines 7734 7734
Hits 5333 5333
Misses 2401 2401
| Files Changed | Coverage Δ |
|---|---|
| ...rosoft.Sbom.Api/Output/Telemetry/TimingRecorder.cs | 0.00% <ø> (ø) |
`[chore: CA1816 Call GC.SuppressFinalize correctly](/microsoft/sbom-tool/pull/375/commits/c7c491eefb96add9fa9b87790d13fca2d6d4c5c1 "chore: CA1816 Call GC.SuppressFinalize correctly
CA1816: Call GC.SuppressFinalize correctly
Related to #340") `
[c7c491e](/microsoft/sbom-tool/pull/375/commits/c7c491eefb96add9fa9b87790d13fca2d6d4c5c1)
CA1816: Call GC.SuppressFinalize correctly
Related to #340
sebasgomez238 approved these changes Sep 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
1 more reviewer
Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
3 participants
