refactor: IDE0007 Use var instead of explicit type by JamieMagee · Pull Request #405 · microsoft/sbom-tool (original) (raw)

Skip to content

Sign in

Appearance settings

View all features

View all solutions

View all resources

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

microsoft / sbom-tool Public

Additional navigation options

Merged

JamieMagee

merged 2 commits into

mainfrom

users/jamagee/IDE0007

Sep 26, 2023

ConversationCommits (2)ChecksFiles changed

Merged

refactor: IDE0007 Use var instead of explicit type#405

JamieMagee

merged 2 commits into

mainfrom

users/jamagee/IDE0007

Conversation

@JamieMagee

@JamieMagee JamieMagee commented

Sep 25, 2023

Copy link Copy Markdown

Member

IDE0007: Use var instead of explicit type

Related to #340

@JamieMagee

[refactor: IDE0007 Use var instead of explicit type](/microsoft/sbom-tool/pull/405/commits/963b37a389a620de0aa3cc0ba634892126534022 "refactor: IDE0007 Use `var` instead of explicit type")

[963b37a](/microsoft/sbom-tool/pull/405/commits/963b37a389a620de0aa3cc0ba634892126534022)

@JamieMagee JamieMagee requested a review from a team as a code owner

September 25, 2023 21:59

@JamieMagee JamieMagee requested review fromjiaw37 and ryanbrandenburg

September 25, 2023 21:59

@codecov-commenter

codecov-commenter commented

Sep 25, 2023

edited

Loading

Copy link Copy Markdown

Codecov Report

Merging #405 (1eb8555) into main (4c9ec94) will not change coverage.
The diff coverage is 79.87%.

@@ Coverage Diff @@ ## main #405 +/- ##

Coverage 69.01% 69.01%

Files 242 242
Lines 7772 7772

Hits 5364 5364
Misses 2408 2408

Files Coverage Δ
...Adapters/ComponentDetectionToSBOMPackageAdapter.cs 80.00% <100.00%> (ø)
...crosoft.Sbom.Api/Config/ApiConfigurationBuilder.cs 74.79% <100.00%> (ø)
src/Microsoft.Sbom.Api/Config/ConfigFileParser.cs 81.81% <100.00%> (ø)
src/Microsoft.Sbom.Api/Config/ConfigSanitizer.cs 76.66% <100.00%> (ø)
...soft.Sbom.Api/Config/Validators/ConfigValidator.cs 75.55% <100.00%> (ø)
...ft.Sbom.Api/Config/Validators/IntRangeValidator.cs 83.33% <100.00%> (ø)
...rters/ComponentToExternalReferenceInfoConverter.cs 95.91% <100.00%> (ø)
...Converters/ExternalReferenceInfoToPathConverter.cs 80.85% <100.00%> (ø)
...om.Api/Converters/SbomToolManifestPathConverter.cs 88.00% <100.00%> (ø)
...icrosoft.Sbom.Api/Entities/FileValidationResult.cs 100.00% <100.00%> (ø)
... and 50 more

@JamieMagee

[Merge branch 'main' into users/jamagee/IDE0007](/microsoft/sbom-tool/pull/405/commits/1eb855517d108c0ce344df8f7a2dcdd22d42cb2f "Merge branch 'main' into users/jamagee/IDE0007")

[1eb8555](/microsoft/sbom-tool/pull/405/commits/1eb855517d108c0ce344df8f7a2dcdd22d42cb2f)

@JamieMagee JamieMageeenabled auto-merge (squash)

September 25, 2023 22:55

sebasgomez238

sebasgomez238 approved these changes Sep 26, 2023

View reviewed changes

@JamieMagee JamieMagee merged commit 9f70e69 into main

Sep 26, 2023

@JamieMagee JamieMagee deleted the users/jamagee/IDE0007 branch

September 26, 2023 13:16

@JamieMagee JamieMagee mentioned this pull request

Sep 26, 2023

Fix analyzer warnings#340

Open

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jiaw37 jiaw37 Awaiting requested review from jiaw37 jiaw37 is a code owner automatically assigned from microsoft/sbom-pr-reviewers

@ryanbrandenburg ryanbrandenburg Awaiting requested review from ryanbrandenburg ryanbrandenburg is a code owner automatically assigned from microsoft/sbom-pr-reviewers

1 more reviewer

@sebasgomez238 sebasgomez238 sebasgomez238 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JamieMagee @codecov-commenter @sebasgomez238